Bug 196394

Summary: Add more tests for ios iframe scrolling with fixed/sticky layers
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: UI EventsAssignee: Abrar Rahman Protyasha <a_protyasha>
Status: NEW    
Severity: Normal CC: koivisto, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=194900
Bug Depends on: 192303, 194886, 197280    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Additional patch to use immediateScrollElementAtContentPointToOffset
none
Patch
none
Patch (alternative version using immediateScrollElementAtContentPointToOffset) none

Frédéric Wang (:fredw)
Reported 2019-03-29 03:12:18 PDT
I'll import the remaining tests I wrote for ios frame scrolling. Not sure why commits fixed the issues I had, but it seems they all pass now https://bugs.webkit.org/show_bug.cgi?id=194433#c14
Attachments
Patch (15.22 KB, patch)
2019-03-29 03:32 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Additional patch to use immediateScrollElementAtContentPointToOffset (2.84 KB, patch)
2019-03-29 09:00 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (7.73 KB, patch)
2019-04-25 07:20 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (alternative version using immediateScrollElementAtContentPointToOffset) (7.88 KB, patch)
2019-04-25 07:27 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2019-03-29 03:32:22 PDT
Created attachment 366262 [details] Patch
Antti Koivisto
Comment 2 2019-03-29 03:41:24 PDT
Comment on attachment 366262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366262&action=review > LayoutTests/fast/scrolling/ios/scroll-iframe-005.html:29 > + // This checks scrolling to the location of the green square. > + var c = centerOf("positionFixed"); > + await touchAndDragFromPointToPoint(c.x, c.y, c.x - 150, c.y - 150); > + await liftUpAtPoint(c.x - 150, c.y - 150); > + > + // Wait for scrolling to stabilize and for scrollbars to disappear. > + setTimeout(() => {testRunner.notifyDone(); }, 1000); Can you make these use UIHelper.immediateScrollElementAtContentPointToOffset and remove the timeouts? See LayoutTests/fast/scrolling/ios/overflow-scroll-overlap.html (and LayoutTests/fast/scrolling/resources/overflow-scroll-overlap.js) for an example.
Frédéric Wang (:fredw)
Comment 3 2019-03-29 09:00:08 PDT
Created attachment 366274 [details] Additional patch to use immediateScrollElementAtContentPointToOffset
Frédéric Wang (:fredw)
Comment 4 2019-03-29 09:01:25 PDT
Comment on attachment 366262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366262&action=review >> LayoutTests/fast/scrolling/ios/scroll-iframe-005.html:29 >> + setTimeout(() => {testRunner.notifyDone(); }, 1000); > > Can you make these use UIHelper.immediateScrollElementAtContentPointToOffset and remove the timeouts? See > > LayoutTests/fast/scrolling/ios/overflow-scroll-overlap.html (and LayoutTests/fast/scrolling/resources/overflow-scroll-overlap.js) > > for an example. Mmh, I tried it (attachment 366274 [details]) but that does not seem to work. Not sure which mistake I made...
Simon Fraser (smfr)
Comment 5 2019-03-29 14:07:11 PDT
Comment on attachment 366262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366262&action=review >>> LayoutTests/fast/scrolling/ios/scroll-iframe-005.html:29 >>> + setTimeout(() => {testRunner.notifyDone(); }, 1000); >> >> Can you make these use UIHelper.immediateScrollElementAtContentPointToOffset and remove the timeouts? See >> >> LayoutTests/fast/scrolling/ios/overflow-scroll-overlap.html (and LayoutTests/fast/scrolling/resources/overflow-scroll-overlap.js) >> >> for an example. > > Mmh, I tried it (attachment 366274 [details]) but that does not seem to work. Not sure which mistake I made... I think it's worth trying. You're adding 2s of tests, and that's not a sustainable rate.
Frédéric Wang (:fredw)
Comment 6 2019-04-01 12:24:09 PDT
(In reply to Simon Fraser (smfr) from comment #5) > >> LayoutTests/fast/scrolling/ios/overflow-scroll-overlap.html (and LayoutTests/fast/scrolling/resources/overflow-scroll-overlap.js) > >> > >> for an example. > > > > Mmh, I tried it (attachment 366274 [details]) but that does not seem to work. Not sure which mistake I made... > > I think it's worth trying. You're adding 2s of tests, and that's not a > sustainable rate. Yes, I agree with that. The thing is that I was not sure whether I made something wrong in my attempt attachment 366274 [details] as the change makes the test then fails when I tried the other day. Not sure why they pass with the other API.
Frédéric Wang (:fredw)
Comment 7 2019-04-25 06:40:45 PDT
(In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 366262 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=366262&action=review > > >>> LayoutTests/fast/scrolling/ios/scroll-iframe-005.html:29 > >>> + setTimeout(() => {testRunner.notifyDone(); }, 1000); > >> > >> Can you make these use UIHelper.immediateScrollElementAtContentPointToOffset and remove the timeouts? See > >> > >> LayoutTests/fast/scrolling/ios/overflow-scroll-overlap.html (and LayoutTests/fast/scrolling/resources/overflow-scroll-overlap.js) > >> > >> for an example. > > > > Mmh, I tried it (attachment 366274 [details]) but that does not seem to work. Not sure which mistake I made... > > I think it's worth trying. You're adding 2s of tests, and that's not a > sustainable rate. I'm still not able to make them pass with the internal APIs so I'll move this to a separate bug and handle the other tests here.
Frédéric Wang (:fredw)
Comment 8 2019-04-25 07:20:21 PDT
Created attachment 368235 [details] Patch Rebasing on top of bug 197280.
Frédéric Wang (:fredw)
Comment 9 2019-04-25 07:27:08 PDT
Created attachment 368236 [details] Patch (alternative version using immediateScrollElementAtContentPointToOffset) With that version, the tests fail for me.
Frédéric Wang (:fredw)
Comment 10 2025-07-07 05:24:18 PDT
Unassigning myself since I'm no longer working on this.
Note You need to log in before you can comment on or make changes to this bug.