Bug 196085

Summary: Remove the SVG tear off objects for SVGPathSeg, SVGPathSegList and SVGAnimatedPathSegList
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: SVGAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, jonlee, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 191237    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Patch none

Said Abou-Hallawa
Reported 2019-03-21 10:17:26 PDT
This is part of removing the tear off objects of the SVG properties.
Attachments
Patch (226.89 KB, patch)
2019-03-22 09:32 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.68 MB, application/zip)
2019-03-22 11:33 PDT, EWS Watchlist 		no flags
Details
Patch (236.16 KB, patch)
2019-03-27 10:35 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-03-21 13:43:14 PDT
<rdar://problem/49121892>
Said Abou-Hallawa
Comment 2 2019-03-22 09:32:22 PDT
Created attachment 365733 [details] Patch
EWS Watchlist
Comment 3 2019-03-22 11:33:29 PDT
Comment on attachment 365733 [details] Patch Attachment 365733 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11614662 New failing tests: perf/svg-path-appenditem.html
EWS Watchlist
Comment 4 2019-03-22 11:33:30 PDT
Created attachment 365751 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Simon Fraser (smfr)
Comment 5 2019-03-25 11:55:25 PDT
Comment on attachment 365733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365733&action=review > Source/WebCore/svg/properties/SVGAnimatedPropertyAnimatorImpl.h:123 > + return std::unique_ptr<SVGAnimatedPathSegListAnimator>(new SVGAnimatedPathSegListAnimator(attributeName, animated, animationMode, calcMode, isAccumulated, isAdditive)); make_unique<>
Said Abou-Hallawa
Comment 6 2019-03-27 10:35:34 PDT
Created attachment 366080 [details] Patch
WebKit Commit Bot
Comment 7 2019-03-27 11:56:12 PDT
Comment on attachment 366080 [details] Patch Clearing flags on attachment: 366080 Committed r243555: <https://trac.webkit.org/changeset/243555>
WebKit Commit Bot
Comment 8 2019-03-27 11:56:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.