Bug 195768

Summary: Web process is put to suspended when holding locked WebSQL files
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Sihui Liu
Reported 2019-03-14 15:05:43 PDT
Web process should not get suspended when it's holding locked database file and performing close.
Attachments
Patch (2.97 KB, patch)
2019-03-14 15:31 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.97 KB, patch)
2019-03-14 18:04 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2019-03-14 15:31:09 PDT
Created attachment 364706 [details] Patch
Geoffrey Garen
Comment 2 2019-03-14 16:17:53 PDT
Comment on attachment 364706 [details] Patch In file included from ./inspector/CommandLineAPIHost.cpp:34: In file included from /Volumes/Data/EWS/WebKit/Source/WebCore/Modules/webdatabase/Database.h:32: /Volumes/Data/EWS/WebKit/Source/WebCore/platform/sql/SQLiteDatabase.h:159:28: error: expected ';' at end of declaration list bool m_useWAL { false }
Geoffrey Garen
Comment 3 2019-03-14 16:51:42 PDT
Comment on attachment 364706 [details] Patch r=me if you fix the build (missing semicolon)
Sihui Liu
Comment 4 2019-03-14 18:04:58 PDT
Created attachment 364744 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-03-14 18:53:39 PDT
The commit-queue encountered the following flaky tests while processing attachment 364744 [details]: loader/load-defer-resume-crash.html bug 195438 (authors: max.hong.shen@gmail.com and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2019-03-14 18:54:28 PDT
Comment on attachment 364744 [details] Patch for landing Clearing flags on attachment: 364744 Committed r242983: <https://trac.webkit.org/changeset/242983>
WebKit Commit Bot
Comment 7 2019-03-14 18:54:30 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-03-14 18:55:18 PDT
<rdar://problem/48912114>
Note You need to log in before you can comment on or make changes to this bug.