Bug 195557

Summary: [ews-build] unit-tests fail when passwords.json is missing
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=180390
Attachments:
Description Flags
Proposed patch none

Aakash Jain
Reported 2019-03-11 08:25:06 PDT
unit-tests in loadConfig_unittest.py fail when passwords.json is missing. This file is not checked-in to the repository. So the unit-tests should be able to run without this file. Exception: [~/OpenSource/Tools/BuildSlaveSupport/ews-build]$python runUnittests.py ......................................................E.................... ====================================================================== ERROR: test_configuration (loadConfig_unittest.ConfigDotJSONTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/jain/code/OpenSource/Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py", line 36, in test_configuration loadConfig.loadBuilderConfig({}, master_prefix_path=cwd) File "/Users/jain/code/OpenSource/Tools/BuildSlaveSupport/ews-build/loadConfig.py", line 42, in loadBuilderConfig passwords = json.load(open(os.path.join(master_prefix_path, 'passwords.json'))) IOError: [Errno 2] No such file or directory: 'passwords.json'
Attachments
Proposed patch (3.06 KB, patch)
2019-03-11 08:29 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-03-11 08:29:34 PDT
Created attachment 364253 [details] Proposed patch
WebKit Commit Bot
Comment 2 2019-03-11 09:38:11 PDT
Comment on attachment 364253 [details] Proposed patch Clearing flags on attachment: 364253 Committed r242707: <https://trac.webkit.org/changeset/242707>
WebKit Commit Bot
Comment 3 2019-03-11 09:38:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-03-11 09:39:23 PDT
<rdar://problem/48769818>
Note You need to log in before you can comment on or make changes to this bug.