Bug 194701
| Summary: | REGRESSION(r240250): buildbot console view popup is not correctly positioned since r240250 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | aakash_jain, ahmad.saleem792, ap, fred.wang, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar, Regression |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=189472 | ||
Carlos Garcia Campos
Steps to reproduce:
1. Go to https://build.webkit.org/console
2. Scroll down a bit
3. Click on any bubble
4. The popup is not shown, because it's positioned at the top of the page, scroll up and you will see the it there.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Frédéric Wang (:fredw)
showBuildBox() should probably use document.scrollingElement instead of document.body to get the scroll offset.
Carlos Garcia Campos
Shouldn't this be backwards compatible? There might be more websites broken.
Frédéric Wang (:fredw)
(In reply to Carlos Garcia Campos from comment #2)
> Shouldn't this be backwards compatible? There might be more websites broken.
Yes this change was expected to break existing content. See https://lists.webkit.org/pipermail/webkit-dev/2018-January/029857.html
https://lists.webkit.org/pipermail/webkit-dev/2018-September/030122.html
for details.
Simon Fraser (smfr)
Does the bug reproduce in Chrome?
Frédéric Wang (:fredw)
(In reply to Simon Fraser (smfr) from comment #4)
> Does the bug reproduce in Chrome?
Yes it reproduces in Chrome but for some reason not in Firefox. Maybe they have different interpretation of whether to use quirks mode with XHTML pages.
Radar WebKit Bug Importer
<rdar://problem/48135567>
Ahmad Saleem
Pop-up are showing fine - https://build.webkit.org/#/console
Is this still an issue? Thanks!
Alexey Proskuryakov
We now have a new major version of Buildbot, with entirely rewritten UI.