Bug 194002

<rdar://problem/47656294>

*** Bug 193880 has been marked as a duplicate of this bug. ***

Created attachment 360552 [details] Patch

Comment on attachment 360552 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360552&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:3928 > + if (m_renderView.frame().isMainFrame()) > + scrollingGeometry.parentRelativeScrollableRect = frameView.frameRect(); > + else > + scrollingGeometry.parentRelativeScrollableRect = LayoutRect({ }, LayoutSize(frameView.size())); Why are these cases different? > Source/WebCore/rendering/RenderLayerCompositor.cpp:3980 > + if (const Vector<LayoutUnit>* offsets = layer.horizontalSnapOffsets()) > + scrollingGeometry.horizontalSnapOffsets = *offsets; > + if (const Vector<LayoutUnit>* offsets = layer.verticalSnapOffsets()) > + scrollingGeometry.verticalSnapOffsets = *offsets; > + if (const Vector<ScrollOffsetRange<LayoutUnit>>* ranges = layer.horizontalSnapOffsetRanges()) > + scrollingGeometry.horizontalSnapOffsetRanges = *ranges; > + if (const Vector<ScrollOffsetRange<LayoutUnit>>* ranges = layer.verticalSnapOffsetRanges()) > + scrollingGeometry.verticalSnapOffsetRanges = *ranges; auto*

Comment on attachment 360552 [details] Patch Attachment 360552 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10948296 New failing tests: compositing/overflow/overflow-overlay-with-touch.html compositing/scrolling/overflow-scrolling-layers-are-self-painting.html platform/ios/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container.html compositing/overflow/overflow-auto-with-touch.html compositing/overflow/textarea-scroll-touch.html compositing/overflow/overflow-auto-with-touch-toggle.html compositing/overflow/scrolling-content-clip-to-viewport.html compositing/rtl/rtl-scrolling-with-transformed-descendants.html compositing/overflow/scrolling-without-painting.html compositing/overflow/updating-scrolling-content.html

Created attachment 360559 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

(In reply to Antti Koivisto from comment #6) > Comment on attachment 360552 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=360552&action=review > > > Source/WebCore/rendering/RenderLayerCompositor.cpp:3928 > > + if (m_renderView.frame().isMainFrame()) > > + scrollingGeometry.parentRelativeScrollableRect = frameView.frameRect(); > > + else > > + scrollingGeometry.parentRelativeScrollableRect = LayoutRect({ }, LayoutSize(frameView.size())); > > Why are these cases different? For subframes, we don't want the FrameView's location (which is the offset from its parent Widget). I guess the root FrameView always has a location of 0,0? I'd have to check with top insets, headers etc. > > > Source/WebCore/rendering/RenderLayerCompositor.cpp:3980 > > + if (const Vector<LayoutUnit>* offsets = layer.horizontalSnapOffsets()) > > + scrollingGeometry.horizontalSnapOffsets = *offsets; > > + if (const Vector<LayoutUnit>* offsets = layer.verticalSnapOffsets()) > > + scrollingGeometry.verticalSnapOffsets = *offsets; > > + if (const Vector<ScrollOffsetRange<LayoutUnit>>* ranges = layer.horizontalSnapOffsetRanges()) > > + scrollingGeometry.horizontalSnapOffsetRanges = *ranges; > > + if (const Vector<ScrollOffsetRange<LayoutUnit>>* ranges = layer.verticalSnapOffsetRanges()) > > + scrollingGeometry.verticalSnapOffsetRanges = *ranges; > > auto* Right.

Also this is just the start. We'll also need geometry info for the viewport-contained layers, so I expect this to get more complicated. I also want to build a way to test this without having to generate wheel events.