Bug 193924

Summary: StorageAccess API calls should be direct to the Network Process
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, machucovjorge, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 193705    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch achristensen: review+

Brent Fulgham
Reported 2019-01-28 14:29:14 PST
The current implementation of the Storage Access API messages the UI Process, which in turn messages the Network Process for answers. We should avoid this extra hop through the UIProcess, since the state is held entirely in the Network Process. The one exception is when a user prompt is needed, but that should be triggered by the Network Process requesting the UI Process perform that interaction.
Attachments
Patch (34.72 KB, patch)
2019-01-29 10:05 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (34.78 KB, patch)
2019-01-29 10:16 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (35.28 KB, patch)
2019-01-29 10:26 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (35.72 KB, patch)
2019-01-29 10:32 PST, Brent Fulgham 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-28 14:30:57 PST
<rdar://problem/47611249>
Brent Fulgham
Comment 2 2019-01-29 10:05:39 PST
Created attachment 360468 [details] Patch
Brent Fulgham
Comment 3 2019-01-29 10:16:03 PST
Created attachment 360469 [details] Patch
Brent Fulgham
Comment 4 2019-01-29 10:26:28 PST
Created attachment 360470 [details] Patch
Brent Fulgham
Comment 5 2019-01-29 10:32:24 PST
Created attachment 360471 [details] Patch
Alex Christensen
Comment 6 2019-01-29 11:43:39 PST
Comment on attachment 360471 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360471&action=review r=me with one minor change. > Source/WebKit/UIProcess/WebPageProxy.h:1383 > + static void requestStorageAccessConfirm(uint64_t pageID, uint64_t frameID, const String& subFrameHost, const String& topFrameHost, CompletionHandler<void(bool)>&&); This should not be static. The NetworkProcessProxy should find the correct WebPageProxy and call a member function on it.
Brent Fulgham
Comment 7 2019-01-29 13:27:38 PST
Committed r240676: <https://trac.webkit.org/changeset/240676>
Note You need to log in before you can comment on or make changes to this bug.