Bug 193660
| Summary: | REGRESSION (r240243): Caused an API tests to fail | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, bfulgham, mcatanzaro, ryanhaddad, tsavell, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 193556 | ||
| Bug Blocks: | |||
Brent Fulgham
Correct an API test failure introduced by my changes in r240243.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/47433602>
Brent Fulgham
My original patch was incrementing the pending callback count before deciding if a callback was actually needed. This left it out of balance, preventing the callback from ever firing.
Brent Fulgham
Committed r240247: <https://trac.webkit.org/changeset/240247>
Alexey Proskuryakov
Yay tests!
Brent Fulgham
(In reply to Alexey Proskuryakov from comment #4)
> Yay tests!
And for actually paying attention to them! :-)
Michael Catanzaro
Committed r240308: <https://trac.webkit.org/changeset/240308>