Bug 193319

Summary: [WPE] API test gardening
Product: WebKit Reporter: Charlie Turner <cturner>
Component: WPE WebKitAssignee: Charlie Turner <cturner>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, loic.yhuel, mcatanzaro, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Charlie Turner
Reported 2019-01-10 07:19:25 PST
[WPE] API test gardening
Attachments
Patch (5.49 KB, patch)
2019-01-10 08:35 PST, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Patch (4.03 KB, patch)
2019-01-10 12:42 PST, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.06 KB, patch)
2019-01-14 04:02 PST, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Charlie Turner
Comment 1 2019-01-10 08:35:41 PST
Created attachment 358796 [details] Patch
Loïc Yhuel
Comment 2 2019-01-10 10:44:29 PST
Comment on attachment 358796 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358796&action=review > Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:85 > +#if PLATFORM(WIN) || U_ICU_VERSION_MAJOR_NUM >= 58 U_ICU_VERSION_MAJOR_NUM >= 59 ICU 58 has the old UChar definition.
Michael Catanzaro
Comment 3 2019-01-10 12:04:43 PST
The ICU change should be split into a different bug.
Charlie Turner
Comment 4 2019-01-10 12:42:25 PST
Created attachment 358819 [details] Patch Split the ICU fix into a separate patch, this one now deals only with newly passing API tests on WPE
Charlie Turner
Comment 5 2019-01-10 12:52:44 PST
Please see https://bugs.webkit.org/show_bug.cgi?id=193332 for the ICU stuff splitted out
Charlie Turner
Comment 6 2019-01-14 04:02:43 PST
Created attachment 359028 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-01-14 04:41:07 PST
Comment on attachment 359028 [details] Patch for landing Clearing flags on attachment: 359028 Committed r239922: <https://trac.webkit.org/changeset/239922>
WebKit Commit Bot
Comment 8 2019-01-14 04:41:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.