Bug 193003

Summary:

Only hyphenate text for which there is a language specified

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

Text

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ews-watchlist, mmaxfield, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

193002

Attachments:

Description	Flags
Patch	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews112 for mac-sierra	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none

Myles C. Maxfield

Reported 2018-12-21 19:55:52 PST

Only hyphenate text for which there is a language specified

Attachments
Patch (8.85 KB, patch) 2018-12-21 19:58 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (6.42 KB, patch) 2018-12-21 20:17 PST, Myles C. Maxfield	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.44 MB, application/zip) 2018-12-21 21:18 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-sierra (1.97 MB, application/zip) 2018-12-21 22:08 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.72 MB, application/zip) 2018-12-21 22:15 PST, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2018-12-21 19:58:25 PST

Created attachment 358015 [details] Patch

Myles C. Maxfield

Comment 2 2018-12-21 20:17:54 PST

Created attachment 358016 [details] Patch

EWS Watchlist

Comment 3 2018-12-21 21:18:31 PST

Comment on attachment 358016 [details] Patch Attachment 358016 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10515819 New failing tests: editing/spelling/spelling-marker-includes-hyphen.html

EWS Watchlist

Comment 4 2018-12-21 21:18:33 PST

Created attachment 358017 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-12-21 22:08:25 PST

Comment on attachment 358016 [details] Patch Attachment 358016 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10515896 New failing tests: editing/spelling/spelling-marker-includes-hyphen.html

EWS Watchlist

Comment 6 2018-12-21 22:08:27 PST

Created attachment 358018 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-12-21 22:15:11 PST

Comment on attachment 358016 [details] Patch Attachment 358016 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10516088 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html editing/spelling/spelling-marker-includes-hyphen.html

EWS Watchlist

Comment 8 2018-12-21 22:15:13 PST

Created attachment 358020 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Alex Christensen

Comment 9 2021-11-01 12:18:13 PDT

Comment on attachment 358016 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.

Vitaly Dyackhov

Comment 10 2024-08-02 06:36:17 PDT

Pull request: https://github.com/WebKit/WebKit/pull/31643

EWS

Comment 11 2024-09-27 06:16:53 PDT

Committed 284355@main (32780e4c841e): <https://commits.webkit.org/284355@main> Reviewed commits have been landed. Closing PR #31643 and removing active labels.

Radar WebKit Bug Importer

Comment 12 2024-09-27 06:17:21 PDT

<rdar://problem/136826305>

Note You need to log in before you can comment on or make changes to this bug.