Bug 192425

Summary: [iOS] Add test to ensure that a web page can prevent the default for Command + A
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Layout and RenderingAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, rniwa, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar, PlatformOnly
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 12   
See Also: https://bugs.webkit.org/show_bug.cgi?id=190571
Bug Depends on:    
Bug Blocks: 190571    
Attachments:
Description Flags
Layout test
wenson_hsieh: review+
Archive of layout-test-results from ews102 for mac-sierra none

Daniel Bates
Reported 2018-12-05 13:44:03 PST
We should add a test to ensure that a web page can prevent the default for Command + A. For now, we need to skip this test until we have the UIKit fix for <rdar://problem/46430796>.
Attachments
Layout test (3.17 KB, patch)
2018-12-05 13:46 PST, Daniel Bates 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-sierra (2.68 MB, application/zip)
2018-12-05 19:03 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-12-05 13:46:04 PST
Created attachment 356653 [details] Layout test
EWS Watchlist
Comment 2 2018-12-05 19:03:41 PST
Comment on attachment 356653 [details] Layout test Attachment 356653 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10286576 New failing tests: http/tests/misc/resource-timing-resolution.html
EWS Watchlist
Comment 3 2018-12-05 19:03:43 PST
Created attachment 356694 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Wenson Hsieh
Comment 4 2018-12-05 19:06:48 PST
Comment on attachment 356653 [details] Layout test View in context: https://bugs.webkit.org/attachment.cgi?id=356653&action=review > LayoutTests/fast/events/ios/key-command-select-all-prevent-default.html:9 > +let testElement; Nit - Is this necessary?
Daniel Bates
Comment 5 2019-03-12 10:23:09 PDT
Committed r242800: <https://trac.webkit.org/changeset/242800>
Radar WebKit Bug Importer
Comment 6 2019-03-12 10:24:21 PDT
<rdar://problem/48812610>
Daniel Bates
Comment 7 2019-03-12 10:24:58 PDT
(In reply to Wenson Hsieh from comment #4) > Comment on attachment 356653 [details] > Layout test > > View in context: > https://bugs.webkit.org/attachment.cgi?id=356653&action=review > > > LayoutTests/fast/events/ios/key-command-select-all-prevent-default.html:9 > > +let testElement; > > Nit - Is this necessary? No, I could have written the test to avoid it by making use of event.target. I explicitly chose to add this global because I felt it improves the readability of the code.
Note You need to log in before you can comment on or make changes to this bug.