Bug 192371

Summary:

Fix MediaRecorder flaky tests

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, jlewis3, ryanhaddad, tsavell, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=192069

Bug Depends on:

192414

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch for landing	none

youenn fablet

Reported 2018-12-04 11:41:21 PST

Fix MediaRecorder flaky tests

Attachments
Patch (21.13 KB, patch) 2018-12-04 11:45 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (21.03 KB, patch) 2018-12-04 13:03 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2018-12-04 11:45:23 PST

Created attachment 356523 [details] Patch

youenn fablet

Comment 2 2018-12-04 13:03:00 PST

Created attachment 356525 [details] Patch for landing

youenn fablet

Comment 3 2018-12-04 13:03:36 PST

(In reply to youenn fablet from comment #2) > Created attachment 356525 [details] > Patch for landing Increased timers compared to first patch for improved stability.

WebKit Commit Bot

Comment 4 2018-12-04 13:40:51 PST

Comment on attachment 356525 [details] Patch for landing Clearing flags on attachment: 356525 Committed r238874: <https://trac.webkit.org/changeset/238874>

WebKit Commit Bot

Comment 5 2018-12-04 13:40:53 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2018-12-04 13:41:29 PST

<rdar://problem/46464224>

Ryan Haddad

Comment 7 2018-12-05 11:04:54 PST

Since this change: http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable.html is frequently failing on Sierra: --- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable-actual.txt @@ -1,4 +1,5 @@ +CONSOLE MESSAGE: line 2659: Error: assert_approx_equals: Red channel of the pixel at (20, 20) expected 255 +/- 50 but got 0 -PASS MediaRecorder can successfully record the video for a video-only stream +FAIL MediaRecorder can successfully record the video for a video-only stream Error: assert_approx_equals: Red channel of the pixel at (20, 20) expected 255 +/- 50 but got 0 https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/8878 http/wpt/mediarecorder/MediaRecorder-AV-audio-only-dataavailable.html continues to be a flaky crash: https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r238881%20(1205)/results.html http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html has failed once on Mojave: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-actual.txt @@ -1,4 +1,5 @@ +CONSOLE MESSAGE: line 2659: Error: assert_approx_equals: Red channel of the pixel at (20, 20) expected 255 +/- 50 but got 0 -PASS MediaRecorder can successfully record the video for a audio-video stream +FAIL MediaRecorder can successfully record the video for a audio-video stream Error: assert_approx_equals: Red channel of the pixel at (20, 20) expected 255 +/- 50 but got 0 https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r238892%20(1216)/results.html

WebKit Commit Bot

Comment 8 2018-12-05 11:16:30 PST

Re-opened since this is blocked by bug 192414

Note You need to log in before you can comment on or make changes to this bug.