Bug 192317

Summary: Web Inspector: Audit: navigating while tests are running should stop and clear all results
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 190754    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2018-12-03 12:34:25 PST
# STEPS TO REPRODUCE 1. open WebInspector 2. enable the Audit tab 3. load the default audits 4. start running the test 5. refresh the page => any tests with results are cleared, but all active tests (e.g. one's that have been queued but not yet run) continue running # NOTE For (4), it may be necessary to add an `await Promise.delay(1000)` inside `WI.AuditTestCase.prototype.run`, as the audits can run quite fast
Attachments
Patch (3.64 KB, patch)
2018-12-03 17:06 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-03 15:57:59 PST
<rdar://problem/46435222>
Devin Rousso
Comment 2 2018-12-03 17:06:40 PST
Created attachment 356440 [details] Patch
Joseph Pecoraro
Comment 3 2018-12-03 18:13:34 PST
Comment on attachment 356440 [details] Patch r=me You could write a test for this, but it seems like it could be rather artificial.
Devin Rousso
Comment 4 2018-12-03 19:43:11 PST
Comment on attachment 356440 [details] Patch (In reply to Joseph Pecoraro from comment #3) > You could write a test for this, but it seems like it could be rather artificial. I'd need to wait for <https://webkit.org/b/192171> to land, as I'd need to create a long test that doesn't interfere with the page (e.g. a `setTimeout`), and I'd imagine that that would be pretty flakey.
WebKit Commit Bot
Comment 5 2018-12-03 20:06:38 PST
Comment on attachment 356440 [details] Patch Clearing flags on attachment: 356440 Committed r238841: <https://trac.webkit.org/changeset/238841>
WebKit Commit Bot
Comment 6 2018-12-03 20:06:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.