Bug 191522

Summary: [WebAuthN] PublicKeyCredentialCreationOptions::AuthenticatorSelectionCriteria::AuthenticatorAttachment should be optional
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alex.gaynor, bfulgham, cdumez, commit-queue, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch none

Jiewen Tan
Reported 2018-11-11 17:56:29 PST
PublicKeyCredentialCreationOptions::AuthenticatorSelectionCriteria::AuthenticatorAttachment should be optional.
Attachments
Patch (3.97 KB, patch)
2018-11-14 00:37 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2018-11-14 00:37:58 PST
Created attachment 354777 [details] Patch
Alex Christensen
Comment 2 2018-11-14 06:10:36 PST
Comment on attachment 354777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354777&action=review > Source/WebCore/ChangeLog:11 > + Covered by existing tests. Is there an observable change in behavior from this change?
Brent Fulgham
Comment 3 2018-11-14 08:14:09 PST
Comment on attachment 354777 [details] Patch Looks good. I assume there's no WPT for this, or you would have unskipped it.
Jiewen Tan
Comment 4 2018-11-15 12:02:01 PST
Comment on attachment 354777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354777&action=review Thanks Brent for r+ this patch. >> Source/WebCore/ChangeLog:11 >> + Covered by existing tests. > > Is there an observable change in behavior from this change? Things are a little bit tricky here. There is currently no way of testing the wrong(before) behavior as we only support one kind of authenticators in macOS currently. That means we get the same response if authenticatorAttachment = std::nullopt or CrossPlatform.
WebKit Commit Bot
Comment 5 2018-11-15 12:28:17 PST
Comment on attachment 354777 [details] Patch Clearing flags on attachment: 354777 Committed r238240: <https://trac.webkit.org/changeset/238240>
WebKit Commit Bot
Comment 6 2018-11-15 12:28:19 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-11-15 12:29:35 PST
<rdar://problem/46104073>
Note You need to log in before you can comment on or make changes to this bug.