Bug 191381

Summary: [iOS] Option + Delete should delete previous word
Product: WebKit Reporter: Daniel Bates <dbates>
Component: PlatformAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: megan_gardner, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 12   
See Also: https://bugs.webkit.org/show_bug.cgi?id=191389
Bug Depends on:    
Bug Blocks: 190571    
Attachments:
Description Flags
Patch
none
Patch none

Daniel Bates
Reported 2018-11-07 10:05:30 PST
We should recognize the key command Option + Delete and delete the previous word to more closely match iOS platform conventions.
Attachments
Patch (1.55 KB, patch)
2018-11-07 10:22 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (1.62 KB, patch)
2018-11-07 11:37 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-11-07 10:05:48 PST
<rdar://problem/23681351>
Daniel Bates
Comment 2 2018-11-07 10:22:32 PST
Created attachment 354104 [details] Patch It is not straightforward to write a test for this change because UIKit determines the modifier keys pressed (e.g. Option) by querying the keyboard directly. We could mock out the underlying keyboard though this seems fragile.
Daniel Bates
Comment 3 2018-11-07 11:37:35 PST
Created attachment 354116 [details] Patch
Daniel Bates
Comment 4 2018-11-07 14:12:02 PST
Comment on attachment 354116 [details] Patch Clearing flags on attachment: 354116 Committed r237943: <https://trac.webkit.org/changeset/237943>
Daniel Bates
Comment 5 2018-11-07 14:12:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.