Bug 191215

Summary: Clean up drawLineForDocumentMarker()
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 190774    
Attachments:
Description Flags
Patch
zalan: review+
Patch for committing commit-queue: commit-queue-

Myles C. Maxfield
Reported 2018-11-02 15:25:00 PDT
Clean up drawLineForDocumentMarker()
Attachments
Patch (44.34 KB, patch)
2018-11-02 15:32 PDT, Myles C. Maxfield 		zalan: review+
DetailsFormatted DiffDiff
Patch for committing (44.64 KB, patch)
2018-11-02 17:24 PDT, Myles C. Maxfield 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2018-11-02 15:32:51 PDT
Created attachment 353737 [details] Patch
Myles C. Maxfield
Comment 2 2018-11-02 17:24:01 PDT
Created attachment 353750 [details] Patch for committing
WebKit Commit Bot
Comment 3 2018-11-02 17:25:38 PDT
Comment on attachment 353750 [details] Patch for committing Rejecting attachment 353750 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 353750, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Alan Bujtas found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/9838535
Myles C. Maxfield
Comment 4 2018-11-02 19:36:38 PDT
Committed r237765: <https://trac.webkit.org/changeset/237765>
Radar WebKit Bug Importer
Comment 5 2018-11-02 19:37:22 PDT
<rdar://problem/45779882>
Note You need to log in before you can comment on or make changes to this bug.