Bug 190717

Summary: [PSON] WebPageProxy::didCompletePageTransition() may interact with a SuspendedPageProxy from a previous navigation
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ews-watchlist, ggaren, koivisto, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=190687
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews205 for win-future none

Chris Dumez
Reported 2018-10-18 09:13:02 PDT
WebPageProxy::didCompletePageTransition() may interact with a SuspendedPageProxy from a previous navigation. We need to reset m_lastSuspendedPage whenever the page starts a new navigation as m_lastSuspendedPage is only updated when we process-swap otherwise.
Attachments
Patch (5.56 KB, patch)
2018-10-18 09:15 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews205 for win-future (12.71 MB, application/zip)
2018-10-18 11:05 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-10-18 09:15:12 PDT
Created attachment 352697 [details] Patch
EWS Watchlist
Comment 2 2018-10-18 11:04:54 PDT
Comment on attachment 352697 [details] Patch Attachment 352697 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9652399 New failing tests: webanimations/leak-document-with-web-animation.html
EWS Watchlist
Comment 3 2018-10-18 11:05:05 PDT
Created attachment 352708 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Chris Dumez
Comment 4 2018-10-18 11:56:54 PDT
Comment on attachment 352708 [details] Archive of layout-test-results from ews205 for win-future Cannot be related.
WebKit Commit Bot
Comment 5 2018-10-19 06:39:39 PDT
Comment on attachment 352697 [details] Patch Clearing flags on attachment: 352697 Committed r237283: <https://trac.webkit.org/changeset/237283>
WebKit Commit Bot
Comment 6 2018-10-19 06:39:40 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-10-19 06:40:56 PDT
<rdar://problem/45404107>
Note You need to log in before you can comment on or make changes to this bug.