Bug 190676

Summary: [GStreamer][WebRTC] properly mark H.264 stream type in the "decoder"
Product: WebKit Reporter: Thibault Saunier <tsaunier>
Component: New BugsAssignee: Thibault Saunier <tsaunier>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, commit-queue, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 190674    
Bug Blocks: 187064, 190677    
Attachments:
Description Flags
Patch none

Thibault Saunier
Reported 2018-10-17 12:04:02 PDT
[GStreamer][WebRTC] properly mark H.264 stream type in the "decoder"
Attachments
Patch (3.84 KB, patch)
2018-10-17 12:04 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thibault Saunier
Comment 1 2018-10-17 12:04:54 PDT
Created attachment 352604 [details] Patch
Philippe Normand
Comment 2 2018-10-17 12:12:53 PDT
Comment on attachment 352604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352604&action=review > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:281 > + if (codecInfo && codecInfo->codecType != webrtc::kVideoCodecH264) Would this really happen? Perhaps could be replaced with an ASSERT?
Thibault Saunier
Comment 3 2018-10-31 04:21:35 PDT
(In reply to Philippe Normand from comment #2) > Comment on attachment 352604 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=352604&action=review > > > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:281 > > + if (codecInfo && codecInfo->codecType != webrtc::kVideoCodecH264) > > Would this really happen? Perhaps could be replaced with an ASSERT? For some reason this is what they do in libwebrtc itself, just did the same here.
WebKit Commit Bot
Comment 4 2018-11-05 07:05:48 PST
Comment on attachment 352604 [details] Patch Clearing flags on attachment: 352604 Committed r237800: <https://trac.webkit.org/changeset/237800>
WebKit Commit Bot
Comment 5 2018-11-05 07:05:49 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-11-05 07:06:22 PST
<rdar://problem/45806531>
Note You need to log in before you can comment on or make changes to this bug.