Bug 190432

Summary: [iOS] Compare input string to UIKeyInput constants using string comparison instead of pointer comparison
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 190571    
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2018-10-10 11:16:21 PDT
Use string comparison when comparing against UIKeyInput constants instead of pointer comparison to make code less fragile should a developer create events using a copy of a UIKeyInput constant or re-creation of the value of a UIKeyInput constant.
Attachments
Patch (2.60 KB, patch)
2018-10-10 11:18 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-10-10 11:18:00 PDT
Created attachment 351973 [details] Patch
Daniel Bates
Comment 2 2018-10-10 11:20:11 PDT
Comment on attachment 351973 [details] Patch Clearing flags on attachment: 351973 Committed r237007: <https://trac.webkit.org/changeset/237007>
Daniel Bates
Comment 3 2018-10-10 11:20:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-10-10 11:21:31 PDT
<rdar://problem/45166709>
Note You need to log in before you can comment on or make changes to this bug.