Bug 190305

Summary: Web Inspector: allow multiple canvases to be recorded at the same time
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
URL: https://devinrousso.com/demo/WebKit/canvas.html
Bug Depends on:    
Bug Blocks: 173807, 175485, 190306, 190403    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2018-10-04 23:05:21 PDT
There is no real reason why we can't support recording multiple canvases at the same time. The backend is able to handle it without any issue.
Attachments
Patch (43.10 KB, patch)
2018-10-05 00:53 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (47.21 KB, patch)
2018-10-08 15:13 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-10-05 00:53:05 PDT
Created attachment 351661 [details] Patch
Blaze Burg
Comment 2 2018-10-08 12:30:12 PDT
Comment on attachment 351661 [details] Patch r=me Is it possible to add a test case that starts multiple canvas recordings, triggers frames then waits for all to be stopped?
Devin Rousso
Comment 3 2018-10-08 15:13:23 PDT
Created attachment 351822 [details] Patch
WebKit Commit Bot
Comment 4 2018-10-08 17:14:59 PDT
Comment on attachment 351822 [details] Patch Clearing flags on attachment: 351822 Committed r236952: <https://trac.webkit.org/changeset/236952>
WebKit Commit Bot
Comment 5 2018-10-08 17:15:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-10-08 17:15:24 PDT
<rdar://problem/45111502>
Truitt Savell
Comment 7 2018-10-09 08:29:55 PDT
It looks like https://trac.webkit.org/changeset/236952/webkit Has caused the test inspector/canvas/shaderProgram-add-remove-webgl.html to time out constantly. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcanvas%2FshaderProgram-add-remove-webgl.html
Note You need to log in before you can comment on or make changes to this bug.