Bug 189848

Created attachment 350402 [details] WIP

Comment on attachment 350402 [details] WIP Attachment 350402 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9300872 New failing tests: imported/w3c/web-platform-tests/picture-in-picture/shadow-dom.html imported/w3c/web-platform-tests/picture-in-picture/disable-picture-in-picture.html imported/w3c/web-platform-tests/picture-in-picture/request-picture-in-picture-twice.html imported/w3c/web-platform-tests/picture-in-picture/request-picture-in-picture.html js/dom/dom-static-property-for-in-iteration.html imported/w3c/web-platform-tests/picture-in-picture/picture-in-picture-window.html imported/w3c/web-platform-tests/picture-in-picture/leave-picture-in-picture.html imported/w3c/web-platform-tests/picture-in-picture/picture-in-picture-element.html imported/w3c/web-platform-tests/picture-in-picture/exit-picture-in-picture.html imported/w3c/web-platform-tests/picture-in-picture/enter-picture-in-picture.html

Created attachment 350423 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

We should add this to the feature status page.

Comment on attachment 350402 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=350402&action=review I don't see any ChangeLogs. > Source/WebKit/Configurations/FeatureDefines.xcconfig:162 > +//ENABLE_PICTUREINPICTURE_API = $(ENABLE_PICTUREINPICTURE_API_$(WK_PLATFORM_NAME)); > +//ENABLE_PICTUREINPICTURE_API_iphoneos = $(ENABLE_PICTUREINPICTURE_API$(WK_IOS_12)); > +//ENABLE_PICTUREINPICTURE_API_iphonesimulator = $(ENABLE_PICTUREINPICTURE_API$(WK_IOS_12)); > +//ENABLE_PICTUREINPICTURE_API_IOS_SINCE_12 = ENABLE_PICTUREINPICTURE_API; > +//ENABLE_PICTUREINPICTURE_API_macosx = ENABLE_PICTUREINPICTURE_API; This doesn't look right. > Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig:162 > +//ENABLE_PICTUREINPICTURE_API = $(ENABLE_PICTUREINPICTURE_API_$(WK_PLATFORM_NAME)); > +//ENABLE_PICTUREINPICTURE_API_iphoneos = $(ENABLE_PICTUREINPICTURE_API$(WK_IOS_12)); > +//ENABLE_PICTUREINPICTURE_API_iphonesimulator = $(ENABLE_PICTUREINPICTURE_API$(WK_IOS_12)); > +//ENABLE_PICTUREINPICTURE_API_IOS_SINCE_12 = ENABLE_PICTUREINPICTURE_API; > +//ENABLE_PICTUREINPICTURE_API_macosx = ENABLE_PICTUREINPICTURE_API; Ditto. > Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:162 > +//ENABLE_PICTUREINPICTURE_API = $(ENABLE_PICTUREINPICTURE_API_$(WK_PLATFORM_NAME)); > +//ENABLE_PICTUREINPICTURE_API_iphoneos = $(ENABLE_PICTUREINPICTURE_API$(WK_IOS_12)); > +//ENABLE_PICTUREINPICTURE_API_iphonesimulator = $(ENABLE_PICTUREINPICTURE_API$(WK_IOS_12)); > +//ENABLE_PICTUREINPICTURE_API_IOS_SINCE_12 = ENABLE_PICTUREINPICTURE_API; > +//ENABLE_PICTUREINPICTURE_API_macosx = ENABLE_PICTUREINPICTURE_API; Ditto.

Hi Jeremy, do you plan to continue working on this? If not, I would like to play around with this in the next few weeks and see if I can send a patch.

(In reply to Carlos Eduardo Ramalho from comment #7) > Hi Jeremy, do you plan to continue working on this? > > If not, I would like to play around with this in the next few weeks and see > if I can send a patch. > Jeremy is no longer actively contributing to WebKit. Please feel free to take this over, I'll be happy to review patches!

(In reply to Eric Carlson from comment #8) > (In reply to Carlos Eduardo Ramalho from comment #7) > > Hi Jeremy, do you plan to continue working on this? > > > > If not, I would like to play around with this in the next few weeks and see > > if I can send a patch. > > > Jeremy is no longer actively contributing to WebKit. Please feel free to > take this over, I'll be happy to review patches! Great! I see that bug 182688 also exists and is referred at https://github.com/WICG/picture-in-picture/blob/master/implementation-status.md Maybe this bug would be a duplicate of that one?

(In reply to Carlos Eduardo Ramalho from comment #9) > (In reply to Eric Carlson from comment #8) > > (In reply to Carlos Eduardo Ramalho from comment #7) > > > Hi Jeremy, do you plan to continue working on this? > > > > > > If not, I would like to play around with this in the next few weeks and see > > > if I can send a patch. > > > > > Jeremy is no longer actively contributing to WebKit. Please feel free to > > take this over, I'll be happy to review patches! > > Great! > > I see that bug 182688 also exists and is referred at > https://github.com/WICG/picture-in-picture/blob/master/implementation-status. > md > > Maybe this bug would be a duplicate of that one? Indeed, I have duped this to bug 182688. *** This bug has been marked as a duplicate of bug 182688 ***