Bug 189808

Summary: Web Inspector: remove Legacy Style Editor
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, inspector-bugzilla-changes, joepeck, rniwa, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 183627, 189807    
Bug Blocks: 189864    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-sierra
none
Patch
none
Archive of layout-test-results from ews103 for mac-sierra
none
Archive of layout-test-results from ews106 for mac-sierra-wk2
none
Patch none

Devin Rousso
Reported 2018-09-20 16:28:24 PDT
The Legacy Style Editor has been hidden behind an "experimental" setting for almost a year. It's time that we remove it, especially since the new Style Editor is at a similar, if not more advanced, state.
Attachments
Patch (224.07 KB, patch)
2018-09-20 19:45 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-sierra (2.01 MB, application/zip)
2018-09-20 20:18 PDT, EWS Watchlist 		no flags
Details
Patch (242.66 KB, patch)
2018-09-20 21:20 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-sierra (2.43 MB, application/zip)
2018-09-20 22:26 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.47 MB, application/zip)
2018-09-20 22:59 PDT, EWS Watchlist 		no flags
Details
Patch (255.00 KB, patch)
2018-09-20 23:06 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-09-20 19:45:45 PDT
Created attachment 350308 [details] Patch
EWS Watchlist
Comment 2 2018-09-20 20:18:53 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 3 2018-09-20 20:18:54 PDT Comment hidden (obsolete)
Devin Rousso
Comment 4 2018-09-20 21:20:43 PDT
Created attachment 350323 [details] Patch Forgot to upload my changes to what files are included
EWS Watchlist
Comment 5 2018-09-20 22:26:48 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 6 2018-09-20 22:26:49 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 7 2018-09-20 22:59:51 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 8 2018-09-20 22:59:53 PDT Comment hidden (obsolete)
Devin Rousso
Comment 9 2018-09-20 23:06:13 PDT
Created attachment 350333 [details] Patch
Joseph Pecoraro
Comment 10 2018-09-21 10:55:04 PDT
Comment on attachment 350333 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350333&action=review r=me. Awesome, this looks like a pretty thorough removal! > Source/WebInspectorUI/ChangeLog:16 > + * Tools/PrettyPrinting/index.html: Nice! > Source/WebInspectorUI/ChangeLog:104 > + * UserInterface/Views/CodeMirrorFormatters.js: > + Remove "css-rule" CodeMirror mode. The CodeMirror "javascript" formatter in here can actually be removed as well. I always thought we might use it for smaller chunks of things but it looks like it is unreachable now. We can remove that in a separate patch. > LayoutTests/inspector/css/css-property.html:190 > - InspectorTest.expectEqual(property.text, "background-repeat-y: repeat;", `"${property.name}" has the text "background-repeat-y: repeat;".`); > + InspectorTest.expectEqual(property.text, "", `"${property.name}" has the text "".`); This seems different.
Devin Rousso
Comment 11 2018-09-21 11:00:16 PDT
Comment on attachment 350333 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350333&action=review >> LayoutTests/inspector/css/css-property.html:190 >> + InspectorTest.expectEqual(property.text, "", `"${property.name}" has the text "".`); > > This seems different. This is explained in a comment on line 175-178 of this file. `CSSProperty.prototype.synthesizedText` was removed, so we no longer synthesize a value. The reason that `background-repeat-x` still has a value is because it is explicitly defined in the `<style>` on line 254 of this file.
WebKit Commit Bot
Comment 12 2018-09-21 11:30:18 PDT
Comment on attachment 350333 [details] Patch Clearing flags on attachment: 350333 Committed r236336: <https://trac.webkit.org/changeset/236336>
WebKit Commit Bot
Comment 13 2018-09-21 11:30:20 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2018-09-21 11:32:00 PDT
<rdar://problem/44686735>
Truitt Savell
Comment 15 2018-09-21 13:28:12 PDT
Looks like https://trac.webkit.org/changeset/236336/webkit Has caused inspector/css/pseudo-element-matches-for-pseudo-element-node.html to fail continuously on Mac Release history: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcss%2Fpseudo-element-matches-for-pseudo-element-node.html Diff: --- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/inspector/css/pseudo-element-matches-for-pseudo-element-node-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/inspector/css/pseudo-element-matches-for-pseudo-element-node-actual.txt @@ -9,8 +9,8 @@ PASS: No Inherited Styles PASS: No Pseudo Element Styles PASS: Has Computed Styles -PROPERTY: content: before; -PROPERTY: color: rgb(0, 0, 255); +PROPERTY: +PROPERTY: MATCHED RULE: SELECTOR: input:before SELECTOR: #x:before [matched]
Note You need to log in before you can comment on or make changes to this bug.