Bug 188637

Summary: Custom element doesn't invalidate its style when :defined rule starts to apply
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: CSSAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, commit-queue, dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, koivisto, rniwa, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154907    
Attachments:
Description Flags
Fixes the bug
none
Archive of layout-test-results from ews101 for mac-sierra
none
Patch for landing none

Ryosuke Niwa
Reported 2018-08-15 22:26:05 PDT
Yet another style recalc bug we have for web components :(
Attachments
Fixes the bug (6.33 KB, patch)
2018-08-15 22:40 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-sierra (2.38 MB, application/zip)
2018-08-15 23:46 PDT, EWS Watchlist 		no flags
Details
Patch for landing (6.43 KB, patch)
2018-08-16 12:32 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-08-15 22:33:33 PDT
<rdar://problem/43366526>
Ryosuke Niwa
Comment 2 2018-08-15 22:40:15 PDT
Created attachment 347247 [details] Fixes the bug
EWS Watchlist
Comment 3 2018-08-15 23:46:53 PDT
Comment on attachment 347247 [details] Fixes the bug Attachment 347247 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8877024 New failing tests: fast/custom-elements/defined-update-style.html
EWS Watchlist
Comment 4 2018-08-15 23:46:55 PDT
Created attachment 347249 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Ryosuke Niwa
Comment 5 2018-08-16 12:32:34 PDT
Created attachment 347286 [details] Patch for landing
Ryosuke Niwa
Comment 6 2018-08-16 12:33:02 PDT
Comment on attachment 347286 [details] Patch for landing Thanks for the review! Wait for EWS again now that I've fixed the test.
WebKit Commit Bot
Comment 7 2018-08-16 13:50:09 PDT
Comment on attachment 347286 [details] Patch for landing Clearing flags on attachment: 347286 Committed r234953: <https://trac.webkit.org/changeset/234953>
WebKit Commit Bot
Comment 8 2018-08-16 13:50:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.