Bug 188534

Summary: Web Inspector: Table should handle row selection instead of the table delegate
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch for landing none

Matt Baker
Reported 2018-08-13 14:47:33 PDT
To prevent selection, the table delegate can implement `tableShouldSelectRow`, similar to NSTableViewDelegate's shouldSelectRow.
Attachments
Patch (5.00 KB, patch)
2018-08-13 14:54 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.03 KB, patch)
2018-08-13 15:05 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-08-13 14:47:57 PDT
<rdar://problem/43253335>
Matt Baker
Comment 2 2018-08-13 14:54:18 PDT
Created attachment 347043 [details] Patch
Joseph Pecoraro
Comment 3 2018-08-13 15:01:36 PDT
Comment on attachment 347043 [details] Patch r=me
Joseph Pecoraro
Comment 4 2018-08-13 15:02:29 PDT
Comment on attachment 347043 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347043&action=review > Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js:43 > + tableShouldSelectRow(table, cell, column, rowIndex) This should be under the delegate section (~20 lines down), not the data source.
Matt Baker
Comment 5 2018-08-13 15:05:23 PDT
Created attachment 347047 [details] Patch for landing
WebKit Commit Bot
Comment 6 2018-08-13 15:44:25 PDT
Comment on attachment 347047 [details] Patch for landing Clearing flags on attachment: 347047 Committed r234822: <https://trac.webkit.org/changeset/234822>
WebKit Commit Bot
Comment 7 2018-08-13 15:44:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.