Bug 188419

Summary: Followup (r234683): Element::getAttribute() should return the first non-null attribute value
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: SVGAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, commit-queue, darin, dbates, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=153854
Attachments:
Description Flags
Patch none

Said Abou-Hallawa
Reported 2018-08-08 14:30:07 PDT
This is a follow up for Darin's comments in https://bugs.webkit.org/show_bug.cgi?id=153854. In r234683, a new template function Element::getAttribute() was added to return the first non-empty attribute value. The goal was to handle deprecated attributes in a clean way. Element::getAttribute() should return the first non-null attribute value since an empty string is a legitimate attribute value.
Attachments
Patch (5.22 KB, patch)
2018-08-08 14:44 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2018-08-08 14:44:55 PDT
Created attachment 346799 [details] Patch
WebKit Commit Bot
Comment 2 2018-08-13 09:39:22 PDT
Comment on attachment 346799 [details] Patch Clearing flags on attachment: 346799 Committed r234803: <https://trac.webkit.org/changeset/234803>
WebKit Commit Bot
Comment 3 2018-08-13 09:39:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-08-13 09:40:29 PDT
<rdar://problem/43236643>
Note You need to log in before you can comment on or make changes to this bug.