Bug 187905

Summary: [MediaStream] Restructure getDisplayMedia classes
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jer.noble, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Build fix none

Eric Carlson
Reported 2018-07-23 07:12:43 PDT
Move code that can be shared to the base classes, clean up existing code.
Attachments
Patch (26.89 KB, patch)
2018-07-23 08:09 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (28.02 KB, patch)
2018-07-24 06:09 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.76 KB, patch)
2018-07-24 07:08 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Build fix (1.56 KB, patch)
2018-07-24 11:52 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2018-07-23 08:09:23 PDT
Created attachment 345574 [details] Patch
Radar WebKit Bug Importer
Comment 2 2018-07-23 08:10:17 PDT
<rdar://problem/42500215>
Eric Carlson
Comment 3 2018-07-24 06:09:04 PDT
Created attachment 345666 [details] Patch for landing
Eric Carlson
Comment 4 2018-07-24 07:08:56 PDT
Created attachment 345671 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-07-24 08:04:50 PDT
Comment on attachment 345671 [details] Patch for landing Clearing flags on attachment: 345671 Committed r234146: <https://trac.webkit.org/changeset/234146>
Eric Carlson
Comment 6 2018-07-24 11:52:04 PDT
Created attachment 345696 [details] Build fix
WebKit Commit Bot
Comment 7 2018-07-24 12:31:11 PDT
Comment on attachment 345696 [details] Build fix Clearing flags on attachment: 345696 Committed r234164: <https://trac.webkit.org/changeset/234164>
WebKit Commit Bot
Comment 8 2018-07-24 12:31:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.