Bug 187672

Summary: Replace TR2_OPTIONAL_ASSERTED_EXPRESSION macro in <wtf/Optional.h>
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, fred.wang, mcatanzaro, rniwa, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=187669
https://bugs.webkit.org/show_bug.cgi?id=185159
https://bugs.webkit.org/show_bug.cgi?id=186536
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2018-07-13 16:59:41 PDT
Replace the TR2_OPTIONAL_ASSERTED_EXPRESSION macro in <wtf/Optional.h> since we can use ASSERT_UNDER_CONSTEXPR_CONTEXT() instead. Makes all the assertions more consistent within the class.
Attachments
Patch v1 (3.37 KB, patch)
2018-07-13 17:23 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2018-07-13 17:23:20 PDT
Created attachment 345007 [details] Patch v1
Frédéric Wang (:fredw)
Comment 2 2018-07-13 23:44:01 PDT
Comment on attachment 345007 [details] Patch v1 Yes, I guess the only reason we have this is because we copied it from https://github.com/akrzemi1/Optional/blob/master/optional.hpp#L199.
WebKit Commit Bot
Comment 3 2018-07-14 10:00:01 PDT
Comment on attachment 345007 [details] Patch v1 Clearing flags on attachment: 345007 Committed r233836: <https://trac.webkit.org/changeset/233836>
WebKit Commit Bot
Comment 4 2018-07-14 10:00:03 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-07-14 10:01:18 PDT
<rdar://problem/42202102>
Note You need to log in before you can comment on or make changes to this bug.