Bug 187384

Summary: [Flatpak] HTTP layout tests broken due to missing CGI.pm in the sandbox
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Tools / TestsAssignee: Thibault Saunier <tsaunier>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lforschler, mcatanzaro, tsaunier, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch
none
Patch
none
Patch for landing none

Philippe Normand
Reported 2018-07-06 04:10:13 PDT
...
Attachments
WIP (2.74 KB, patch)
2018-07-06 04:12 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (2.76 KB, patch)
2018-07-06 12:24 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Patch (2.60 KB, patch)
2018-07-06 14:04 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.62 KB, patch)
2018-07-09 05:06 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2018-07-06 04:12:34 PDT
Created attachment 344417 [details] WIP I started a patch but don't have time to finish it right now.
Thibault Saunier
Comment 2 2018-07-06 12:24:03 PDT
Created attachment 344435 [details] Patch
Philippe Normand
Comment 3 2018-07-06 12:56:56 PDT
Comment on attachment 344435 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344435&action=review > Tools/ChangeLog:14 > + Need the bug URL (OOPS!). > + > + Reviewed by NOBODY (OOPS!). > + > + https://bugs.webkit.org/show_bug.cgi?id=187384 > + > + And make it usable inside the sandbox even when > + perl is launched "tainted" (as the PERL5LIB won't > + work otherwise). > + > + Reviewed by NOBODY (OOPS!). This is messed up!
Thibault Saunier
Comment 4 2018-07-06 14:04:09 PDT
Created attachment 344451 [details] Patch =I should fix the webkit-patch script at some point :-)
Philippe Normand
Comment 5 2018-07-07 09:17:43 PDT
Ha... bug title doesn't match in changelog...
WebKit Commit Bot
Comment 6 2018-07-07 09:18:18 PDT
Comment on attachment 344451 [details] Patch Rejecting attachment 344451 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 344451, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=344451&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=187384&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 344451 from bug 187384. Fetching: https://bugs.webkit.org/attachment.cgi?id=344451 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Philippe Normand']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 3 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/flatpak/flatpakutils.py Hunk #1 FAILED at 654. 1 out of 1 hunk FAILED -- saving rejects to file Tools/flatpak/flatpakutils.py.rej patching file Tools/flatpak/org.webkit.WebKit.yaml Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Philippe Normand']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/8467185
Philippe Normand
Comment 7 2018-07-09 01:29:20 PDT
This needs some ChangeLog love :)
Philippe Normand
Comment 8 2018-07-09 04:24:53 PDT
Comment on attachment 344451 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344451&action=review > Tools/ChangeLog:3 > + [WPE][GTK] Install perl CGI inside the sandbox This should match the actual bug title
Thibault Saunier
Comment 9 2018-07-09 05:06:35 PDT
Created attachment 344577 [details] Patch for landing
WebKit Commit Bot
Comment 10 2018-07-09 05:45:10 PDT
Comment on attachment 344577 [details] Patch for landing Clearing flags on attachment: 344577 Committed r233639: <https://trac.webkit.org/changeset/233639>
WebKit Commit Bot
Comment 11 2018-07-09 05:45:12 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2018-07-09 05:47:38 PDT
<rdar://problem/41970307>
Note You need to log in before you can comment on or make changes to this bug.