Bug 186534

Summary:

Add a command line default to force WebKitTestRunner to turn on process swap on navigation

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

Tools / Tests

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, ews-watchlist, ggaren, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=186537

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews117 for mac-sierra	none
Patch	none

Brady Eidson

Reported 2018-06-11 11:52:05 PDT

Add a command line default to force WebKitTestRunner to turn on process swap on navigation

Attachments
Patch (6.35 KB, patch) 2018-06-11 12:01 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews117 for mac-sierra (2.99 MB, application/zip) 2018-06-11 13:34 PDT, EWS Watchlist	no flags	Details
Patch (3.95 KB, patch) 2018-06-11 14:05 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2018-06-11 12:01:30 PDT

Created attachment 342453 [details] Patch

Chris Dumez

Comment 2 2018-06-11 12:25:08 PDT

Comment on attachment 342453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342453&action=review > Tools/WebKitTestRunner/TestController.cpp:1126 > + testOptions.enableProcessSwapOnWindowOpen = testOptions.enableProcessSwapOnNavigation; I do not think we want the default to enabled this feature as it is far from ready. The short term plan is to only enable PSON without window open support.

Brady Eidson

Comment 3 2018-06-11 13:24:49 PDT

(In reply to Chris Dumez from comment #2) > Comment on attachment 342453 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342453&action=review > > > Tools/WebKitTestRunner/TestController.cpp:1126 > > + testOptions.enableProcessSwapOnWindowOpen = testOptions.enableProcessSwapOnNavigation; > > I do not think we want the default to enabled this feature as it is far from > ready. The short term plan is to only enable PSON without window open > support. This patch did not change any behavior. Previously if a test enabled PSON, it also got PSOWO That same thing holds true with this patch. The new default *only* enables PSON.

EWS Watchlist

Comment 4 2018-06-11 13:34:45 PDT

Comment on attachment 342453 [details] Patch Attachment 342453 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/8133469 New failing tests: media/video-buffering-allowed.html

EWS Watchlist

Comment 5 2018-06-11 13:34:46 PDT

Created attachment 342458 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6

Chris Dumez

Comment 6 2018-06-11 13:35:25 PDT

Comment on attachment 342453 [details] Patch r=me but needs rebaseline due to <https://trac.webkit.org/changeset/232729>.

Brady Eidson

Comment 7 2018-06-11 13:39:51 PDT

This patch did *not* change the results of the failing video test.

Brady Eidson

Comment 8 2018-06-11 14:05:50 PDT

Created attachment 342463 [details] Patch

WebKit Commit Bot

Comment 9 2018-06-11 14:29:50 PDT

Comment on attachment 342463 [details] Patch Clearing flags on attachment: 342463 Committed r232732: <https://trac.webkit.org/changeset/232732>