Bug 184638

Summary: Flaky Test: animations/needs-layout.html
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: AnimationsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ap, dino, graouts, jlewis3, jonlee, lforschler, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=172397
Bug Depends on:    
Bug Blocks: 50856    
Attachments:
Description Flags
Archive of layout-test-results from webkit-cq-01 none

WebKit Commit Bot
Reported 2018-04-15 14:21:19 PDT
This is an automatically generated bug from the commit-queue. animations/needs-layout.html has been flaky on the commit-queue. animations/needs-layout.html was authored by dino@apple.com. https://trac.webkit.org/browser/trunk/LayoutTests/animations/needs-layout.html The commit-queue just saw animations/needs-layout.html flake (image diff) while processing attachment 337973 [details] on bug 184634. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.12.6 The bots will update this with information from each new failure. If you believe this bug to be fixed or invalid, feel free to close. The bots will re-open if the flake re-occurs. If you would like to track this test fix with another bug, please close this bug as a duplicate. The bots will follow the duplicate chain when making future comments.
Attachments
Archive of layout-test-results from webkit-cq-01 (2.22 MB, application/zip)
2018-04-15 14:21 PDT, WebKit Commit Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2018-04-15 14:21:21 PDT
Created attachment 337977 [details] Archive of layout-test-results from webkit-cq-01
Alexey Proskuryakov
Comment 2 2018-04-15 16:24:53 PDT
This test has been flaky before, but it got worse recently: - http://trac.webkit.org/r230000 broke Gtk Wayland - http://trac.webkit.org/r230632 broke Mac WebKit1, and we are now getting false positives from EWS.
Radar WebKit Bug Importer
Comment 3 2018-04-15 16:25:17 PDT
<rdar://problem/39444962>
Antoine Quint
Comment 4 2018-04-16 04:17:56 PDT
I know why this is happening, we're not forcing a layout for animations that will require them. The old animation code did this in CSSAnimationController::updateAnimations() by calling hasAnimationThatDependsOnLayout() on the CompositeAnimation for the given element.
Antoine Quint
Comment 5 2018-04-17 00:34:07 PDT
Closing as dupe of https://bugs.webkit.org/show_bug.cgi?id=172397 which I fixed. *** This bug has been marked as a duplicate of bug 172397 ***
Note You need to log in before you can comment on or make changes to this bug.