Bug 184515

Summary:

Add support for converting a local window to a remote window

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Page Loading

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, beidson, benjamin, cmarcelo, commit-queue, dbates, esprehn+autocc, ews-watchlist, ggaren, japhet, kangil.han, kondapallykalyan, rniwa, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

184467, 184591, 184640, 184653

Bug Blocks:

184466, 184716

Attachments:

Description	Flags
WIP Patch	none
WIP Patch	none
WIP Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews117 for mac-sierra	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
WIP Patch	none
WIP Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews101 for mac-sierra	none
Archive of layout-test-results from ews115 for mac-sierra	none
WIP Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews101 for mac-sierra	none
Archive of layout-test-results from ews112 for mac-sierra	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
WIP Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2018-04-11 14:19:50 PDT

Add support for converting a local window to a remote window.

Attachments
WIP Patch (168.57 KB, patch) 2018-04-11 14:24 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (168.11 KB, patch) 2018-04-11 14:46 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (168.09 KB, patch) 2018-04-11 14:59 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-sierra (532.55 KB, application/zip) 2018-04-11 16:09 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-sierra (569.67 KB, application/zip) 2018-04-11 16:25 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.32 MB, application/zip) 2018-04-11 16:26 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.79 MB, application/zip) 2018-04-11 16:42 PDT, EWS Watchlist	no flags	Details
WIP Patch (169.72 KB, patch) 2018-04-12 13:03 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (170.43 KB, patch) 2018-04-12 13:21 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-sierra (2.66 MB, application/zip) 2018-04-12 14:43 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-sierra (1.80 MB, application/zip) 2018-04-12 14:53 PDT, EWS Watchlist	no flags	Details
WIP Patch (137.83 KB, patch) 2018-04-12 21:42 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-sierra (2.42 MB, application/zip) 2018-04-12 22:55 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-sierra (1.14 MB, application/zip) 2018-04-12 23:00 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.33 MB, application/zip) 2018-04-12 23:13 PDT, EWS Watchlist	no flags	Details
WIP Patch (138.35 KB, patch) 2018-04-13 12:18 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (137.50 KB, patch) 2018-04-13 12:27 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (110.33 KB, patch) 2018-04-13 15:06 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (124.11 KB, patch) 2018-04-13 16:47 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (124.05 KB, patch) 2018-04-15 15:06 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (110.50 KB, patch) 2018-04-16 13:19 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (45.16 KB, patch) 2018-04-17 10:54 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (55.66 KB, patch) 2018-04-17 12:46 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (55.73 KB, patch) 2018-04-18 09:18 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (23) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2018-04-11 14:20:17 PDT

<rdar://problem/39011318>

Chris Dumez

Comment 2 2018-04-11 14:24:14 PDT

Created attachment 337734 [details] WIP Patch

EWS Watchlist

Comment 3 2018-04-11 14:27:16 PDT

Attachment 337734 [details] did not pass style-queue: ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:185: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 75 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 4 2018-04-11 14:46:53 PDT

Created attachment 337735 [details] WIP Patch

EWS Watchlist

Comment 5 2018-04-11 14:49:07 PDT

Attachment 337735 [details] did not pass style-queue: ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:185: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 74 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 6 2018-04-11 14:59:48 PDT

Created attachment 337737 [details] WIP Patch

EWS Watchlist

Comment 7 2018-04-11 16:09:57 PDT

Comment on attachment 337737 [details] WIP Patch Attachment 337737 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7287980 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 8 2018-04-11 16:09:59 PDT

Created attachment 337740 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 9 2018-04-11 16:25:07 PDT

Comment on attachment 337737 [details] WIP Patch Attachment 337737 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7287941 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 10 2018-04-11 16:25:08 PDT

Created attachment 337742 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 11 2018-04-11 16:26:09 PDT

Comment on attachment 337737 [details] WIP Patch Attachment 337737 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7287988 New failing tests: http/tests/navigation/process-swap-window-open.html

EWS Watchlist

Comment 12 2018-04-11 16:26:11 PDT

Created attachment 337744 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 13 2018-04-11 16:42:20 PDT

Comment on attachment 337737 [details] WIP Patch Attachment 337737 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7288005 New failing tests: http/tests/navigation/process-swap-window-open.html

EWS Watchlist

Comment 14 2018-04-11 16:42:21 PDT

Created attachment 337749 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Chris Dumez

Comment 15 2018-04-12 13:03:38 PDT

Created attachment 337825 [details] WIP Patch

Chris Dumez

Comment 16 2018-04-12 13:21:49 PDT

Created attachment 337830 [details] WIP Patch

EWS Watchlist

Comment 17 2018-04-12 14:43:33 PDT

Comment on attachment 337830 [details] WIP Patch Attachment 337830 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7297793 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 18 2018-04-12 14:43:35 PDT

Created attachment 337837 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 19 2018-04-12 14:53:34 PDT

Comment on attachment 337830 [details] WIP Patch Attachment 337830 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7297779 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 20 2018-04-12 14:53:35 PDT

Created attachment 337839 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6

Chris Dumez

Comment 21 2018-04-12 21:42:39 PDT

Created attachment 337863 [details] WIP Patch

EWS Watchlist

Comment 22 2018-04-12 22:55:18 PDT

Comment on attachment 337863 [details] WIP Patch Attachment 337863 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7301517 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 23 2018-04-12 22:55:20 PDT

Created attachment 337865 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 24 2018-04-12 23:00:58 PDT

Comment on attachment 337863 [details] WIP Patch Attachment 337863 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7301512 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 25 2018-04-12 23:00:59 PDT

Created attachment 337866 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 26 2018-04-12 23:13:02 PDT

Comment on attachment 337863 [details] WIP Patch Attachment 337863 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7301546 New failing tests: media/video-frame-accurate-seek.html

EWS Watchlist

Comment 27 2018-04-12 23:13:04 PDT

Created attachment 337867 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Chris Dumez

Comment 28 2018-04-13 12:18:30 PDT

Created attachment 337917 [details] WIP Patch

Chris Dumez

Comment 29 2018-04-13 12:27:01 PDT

Created attachment 337919 [details] WIP Patch

Chris Dumez

Comment 30 2018-04-13 15:06:47 PDT

Created attachment 337926 [details] WIP Patch

Chris Dumez

Comment 31 2018-04-13 16:47:42 PDT

Created attachment 337931 [details] WIP Patch

Chris Dumez

Comment 32 2018-04-15 15:06:45 PDT

Created attachment 337979 [details] WIP Patch

Chris Dumez

Comment 33 2018-04-16 13:19:46 PDT

Created attachment 338029 [details] WIP Patch

Chris Dumez

Comment 34 2018-04-17 10:54:48 PDT

Created attachment 338130 [details] WIP Patch

Chris Dumez

Comment 35 2018-04-17 12:46:04 PDT

Created attachment 338144 [details] Patch

Ryosuke Niwa

Comment 36 2018-04-17 20:27:49 PDT

Comment on attachment 338144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338144&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:2441 > + m_mainFrameWindowCreationHandler = [this, previousProcess = WTFMove(previousProcess), previousFrameIdentifier = *previousFrameIdentifier](const GlobalWindowIdentifier& windowIdentifier) { I think it's clearer to call previousProcess as frameOwnerProcess and ownerFrameIdentifier, etc.. since what's important here is that it's the process/frame which opened this frame.

Chris Dumez

Comment 37 2018-04-18 08:54:40 PDT

Comment on attachment 338144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338144&action=review >> Source/WebKit/UIProcess/WebPageProxy.cpp:2441 >> + m_mainFrameWindowCreationHandler = [this, previousProcess = WTFMove(previousProcess), previousFrameIdentifier = *previousFrameIdentifier](const GlobalWindowIdentifier& windowIdentifier) { > > I think it's clearer to call previousProcess as frameOwnerProcess and ownerFrameIdentifier, etc.. > since what's important here is that it's the process/frame which opened this frame. This is not accurate. This is the identifier of the frame that is about to become remote in the old process. This is not the identifier of the frame which opened the new window. I guess the naming needs clarifying either way.

Chris Dumez

Comment 38 2018-04-18 09:18:20 PDT

Created attachment 338221 [details] Patch

WebKit Commit Bot

Comment 39 2018-04-18 09:50:41 PDT

Comment on attachment 338221 [details] Patch Clearing flags on attachment: 338221 Committed r230764: <https://trac.webkit.org/changeset/230764>

WebKit Commit Bot

Comment 40 2018-04-18 09:50:44 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.