Bug 184377

Summary: [WPE] Use GNU install directories
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WPE WebKitAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, cgarcia, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 178894    
Attachments:
Description Flags
Patch cgarcia: review+

Michael Catanzaro
Reported 2018-04-06 17:51:33 PDT
The secondary processes are being installed into bindir, which is inappropriate because they aren't intended to be executed by the user and should not be in PATH. They need to go in libexecdir.
Attachments
Patch (16.86 KB, patch)
2018-04-07 20:08 PDT, Michael Catanzaro 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-04-07 20:08:52 PDT
Created attachment 337438 [details] Patch
Adrian Perez
Comment 2 2018-04-09 03:32:01 PDT
The changes introduced by the patch are indeed the correct thing to do. I am in favor of landing this :-)
Michael Catanzaro
Comment 3 2018-04-09 06:28:28 PDT
I'll fix GTK before landing
Michael Catanzaro
Comment 4 2018-04-09 06:39:13 PDT
I'll enable WEBKIT_EXEC_PATH for WebKitGTK+ before landing as well, which was requested, unless somebody objects.
Carlos Garcia Campos
Comment 5 2018-04-09 07:06:37 PDT
Comment on attachment 337438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337438&action=review > Source/WebKit/Shared/glib/ProcessExecutablePathGLib.cpp:44 > + return String(); return { };
Michael Catanzaro
Comment 6 2018-04-09 07:29:55 PDT
(In reply to Michael Catanzaro from comment #4) > I'll enable WEBKIT_EXEC_PATH for WebKitGTK+ before landing as well, which > was requested, unless somebody objects. Actually this isn't really needed. (In reply to Carlos Garcia Campos from comment #5) > Comment on attachment 337438 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=337438&action=review > > > Source/WebKit/Shared/glib/ProcessExecutablePathGLib.cpp:44 > > + return String(); > > return { }; OK.
Michael Catanzaro
Comment 7 2018-04-09 08:45:52 PDT
Committed r230429: <https://trac.webkit.org/changeset/230429>
Adrian Perez
Comment 8 2018-06-19 13:48:25 PDT
*** Bug 178956 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.