Bug 184374

Summary: Pass FetchOptions and SecurityOrigin as load parameters from WebProcess to NetworkProcess
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Rebased none

youenn fablet
Reported 2018-04-06 17:38:49 PDT
Pass FetchOptions and SecurityOrigin as load parameters from WebProcess to NetworkProcess
Attachments
Patch (31.25 KB, patch)
2018-04-06 17:43 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (33.38 KB, patch)
2018-04-10 16:58 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (32.65 KB, patch)
2018-04-10 17:06 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (33.21 KB, patch)
2018-04-10 17:17 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Rebased (33.24 KB, patch)
2018-04-11 11:09 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-04-06 17:43:03 PDT
Created attachment 337404 [details] Patch
Chris Dumez
Comment 2 2018-04-10 14:23:17 PDT
Comment on attachment 337404 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=337404&action=review Looks good overall but I have one concern. > Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp:91 > + encoder << sourceOrigin->enforcesFilePathSeparation(); Why are we doing this here instead of introducing a (reusable) encoder / decoder for SecurityOrigin class? This looks like a lot of code here for SecurityOrigin internals.
youenn fablet
Comment 3 2018-04-10 14:47:10 PDT
(In reply to Chris Dumez from comment #2) > Comment on attachment 337404 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=337404&action=review > > Looks good overall but I have one concern. > > > Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp:91 > > + encoder << sourceOrigin->enforcesFilePathSeparation(); > > Why are we doing this here instead of introducing a (reusable) encoder / > decoder for SecurityOrigin class? This looks like a lot of code here for > SecurityOrigin internals. The reason is that this currently does not serialize every SecurityOrigin bit, some being only needed for StorageProcess for instance. I will try to update SecurityOrigin to serialize every bit and add the encoder/decoder in SecurityOrigin.h/.cpp directly.
youenn fablet
Comment 4 2018-04-10 16:58:52 PDT
Created attachment 337656 [details] Patch
youenn fablet
Comment 5 2018-04-10 17:06:23 PDT
Created attachment 337657 [details] Patch
youenn fablet
Comment 6 2018-04-10 17:17:18 PDT
Created attachment 337658 [details] Patch
WebKit Commit Bot
Comment 7 2018-04-11 10:28:07 PDT
Comment on attachment 337658 [details] Patch Rejecting attachment 337658 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 337658, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ce/WebKit/NetworkProcess/NetworkResourceLoader.cpp Hunk #1 succeeded at 472 (offset 1 line). patching file Source/WebKit/NetworkProcess/PingLoad.cpp patching file Source/WebKit/NetworkProcess/PingLoad.h patching file Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp patching file Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/7285010
youenn fablet
Comment 8 2018-04-11 11:09:26 PDT
Created attachment 337717 [details] Rebased
WebKit Commit Bot
Comment 9 2018-04-11 12:05:14 PDT
Comment on attachment 337717 [details] Rebased Clearing flags on attachment: 337717 Committed r230541: <https://trac.webkit.org/changeset/230541>
WebKit Commit Bot
Comment 10 2018-04-11 12:05:15 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2018-04-11 12:06:16 PDT
<rdar://problem/39356170>
Note You need to log in before you can comment on or make changes to this bug.