Bug 183131

Summary: Support transferring ImageBitmap objects
Product: WebKit Reporter: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Component: CanvasAssignee: Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, jsbell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 182424    
Attachments:
Description Flags
Patch
none
Patch none

Ms2ger (he/him; ⌚ UTC+1/+2)
Reported 2018-02-26 09:04:02 PST
.
Attachments
Patch (25.45 KB, patch)
2018-02-26 09:13 PST, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
Patch (26.25 KB, patch)
2018-02-26 23:45 PST, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 1 2018-02-26 09:13:36 PST
Created attachment 334620 [details] Patch
EWS Watchlist
Comment 2 2018-02-26 09:15:35 PST
Attachment 334620 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:1787: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:1788: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:1814: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:1815: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:3183: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 5 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 3 2018-02-26 23:45:09 PST
Created attachment 334675 [details] Patch
EWS Watchlist
Comment 4 2018-02-26 23:48:16 PST
Attachment 334675 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:1787: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:1788: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:1814: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:1815: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:3183: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 5 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 5 2018-03-26 05:16:46 PDT
Dino, could you take a look?
WebKit Commit Bot
Comment 6 2018-04-06 12:20:41 PDT
Comment on attachment 334675 [details] Patch Clearing flags on attachment: 334675 Committed r230348: <https://trac.webkit.org/changeset/230348>
WebKit Commit Bot
Comment 7 2018-04-06 12:20:42 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-04-06 12:21:20 PDT
<rdar://problem/39245597>
Note You need to log in before you can comment on or make changes to this bug.