Bug 183078

Summary:

[WebKit] Fix Clang unused parameter warnings of NetworkProcess

Product:

WebKit

Reporter:

Fujii Hironori <Hironori.Fujii>

Component:

WebKit Misc.

Assignee:

Fujii Hironori <Hironori.Fujii>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

achristensen, ap, cdumez, cgarcia, commit-queue, don.olmstead, ews-watchlist, koivisto, mcatanzaro, rniwa, youennf, ysuzuki

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

145121

Attachments:

Description	Flags
warning messages	none
Patch	mcatanzaro: review-, mcatanzaro: commit-queue-

Fujii Hironori

Reported 2018-02-23 03:05:38 PST

[WebKit] Fix Clang warnings of NetworkProcess

Attachments
warning messages (26.37 KB, text/plain) 2018-02-23 03:05 PST, Fujii Hironori	no flags	Details
Patch (15.35 KB, patch) 2018-02-23 03:09 PST, Fujii Hironori	mcatanzaro: review- mcatanzaro: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2018-02-23 03:05:59 PST

Created attachment 334513 [details] warning messages

Fujii Hironori

Comment 2 2018-02-23 03:09:49 PST

Created attachment 334514 [details] Patch

Yusuke Suzuki

Comment 3 2018-02-25 18:56:56 PST

Comment on attachment 334514 [details] Patch r=me

Michael Catanzaro

Comment 4 2018-02-25 19:13:41 PST

Comment on attachment 334514 [details] Patch No, we agreed to build WebKit2 without -Wunused-parameter. (For better or for worse; I actually like that warning.) Fujii, why are you getting these warnings in your build? It should be suppressed by this block in Source/WebKit/CMakeLists.txt: if (COMPILER_IS_GCC_OR_CLANG) WEBKIT_ADD_TARGET_CXX_FLAGS(WebKit -Wno-unused-parameter) WEBKIT_ADD_TARGET_CXX_FLAGS(WebProcess -Wno-unused-parameter) WEBKIT_ADD_TARGET_CXX_FLAGS(NetworkProcess -Wno-unused-parameter) WEBKIT_ADD_TARGET_CXX_FLAGS(StorageProcess -Wno-unused-parameter) endif ()

Michael Catanzaro

Comment 5 2018-02-25 19:17:37 PST

Reference: https://lists.webkit.org/pipermail/webkit-dev/2015-January/027184.html And: bug #142338

Yusuke Suzuki

Comment 6 2018-02-25 19:31:52 PST

(In reply to Michael Catanzaro from comment #4) > Comment on attachment 334514 [details] > Patch > > No, we agreed to build WebKit2 without -Wunused-parameter. (For better or > for worse; I actually like that warning.) > > Fujii, why are you getting these warnings in your build? It should be > suppressed by this block in Source/WebKit/CMakeLists.txt: > > if (COMPILER_IS_GCC_OR_CLANG) > WEBKIT_ADD_TARGET_CXX_FLAGS(WebKit -Wno-unused-parameter) > WEBKIT_ADD_TARGET_CXX_FLAGS(WebProcess -Wno-unused-parameter) > WEBKIT_ADD_TARGET_CXX_FLAGS(NetworkProcess -Wno-unused-parameter) > WEBKIT_ADD_TARGET_CXX_FLAGS(StorageProcess -Wno-unused-parameter) > endif () Oh, I didn't know that WebKit2 has a special rule for this. Thank you.

Fujii Hironori

Comment 7 2018-02-25 20:16:47 PST

Thank you, Michael and Yusuke. I tried again, but can't reproduce the compilation warnings anymore. There might be something wrong in my env. Closed as invalid.

Michael Catanzaro

Comment 8 2018-02-26 08:43:27 PST

(In reply to Yusuke Suzuki from comment #6) > Oh, I didn't know that WebKit2 has a special rule for this. Thank you. Actually, many of our subprojects use -Wno-unused-parameter, e.g. in Tools. It's not just Source/WebKit. I don't like the inconsistency, but that's the status quo.

Note You need to log in before you can comment on or make changes to this bug.