Bug 182539

Summary: Add missing #if ENABLE(VIDEO) after r228092.
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: WebCore Misc.Assignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, don.olmstead, esprehn+autocc, ews-watchlist, gyuyoung.kim, mcatanzaro, Ms2ger, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews100 for mac-sierra
none
Patch
cdumez: commit-queue+
Patch for landing none

Ross Kirsling
Reported 2018-02-06 10:22:47 PST
Created attachment 333188 [details] Patch Fix for https://bugs.webkit.org/show_bug.cgi?id=182388. Definition of ImageBitmap::taintsOrigin must be guarded with ENABLE(VIDEO), otherwise the following error occurs with the feature turned off: > member access into incomplete type 'WebCore::HTMLVideoElement'
Attachments
Patch (857 bytes, patch)
2018-02-06 10:22 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-sierra (2.21 MB, application/zip)
2018-02-06 11:26 PST, EWS Watchlist 		no flags
Details
Patch (1.60 KB, patch)
2018-02-06 12:16 PST, Ross Kirsling 		cdumez: commit-queue+
DetailsFormatted DiffDiff
Patch for landing (1.60 KB, patch)
2018-02-06 12:19 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2018-02-06 11:22:11 PST
Comment on attachment 333188 [details] Patch Rejecting attachment 333188 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 333188, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: org/git/WebKit 588764ad5db..d90d89507ca master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 228183 = 588764ad5db0553c0876b9ed9429030c7457ab05 r228184 = d90d89507ca5dfcb0a7fd1d7271562255300b10b Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/6385177
EWS Watchlist
Comment 2 2018-02-06 11:26:40 PST
Comment on attachment 333188 [details] Patch Attachment 333188 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6385009 New failing tests: media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html
EWS Watchlist
Comment 3 2018-02-06 11:26:41 PST
Created attachment 333195 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Ross Kirsling
Comment 4 2018-02-06 12:16:47 PST
Created attachment 333201 [details] Patch
EWS Watchlist
Comment 5 2018-02-06 12:17:17 PST
Comment on attachment 333201 [details] Patch Rejecting attachment 333201 [details] from review queue. ross.kirsling@sony.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
Ross Kirsling
Comment 6 2018-02-06 12:19:30 PST
Created attachment 333202 [details] Patch for landing
WebKit Commit Bot
Comment 7 2018-02-06 12:55:13 PST
Comment on attachment 333202 [details] Patch for landing Clearing flags on attachment: 333202 Committed r228186: <https://trac.webkit.org/changeset/228186>
WebKit Commit Bot
Comment 8 2018-02-06 12:55:14 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-02-06 12:56:36 PST
<rdar://problem/37285319>
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 10 2018-02-07 07:51:24 PST
Oops, sorry about that.
Note You need to log in before you can comment on or make changes to this bug.