Bug 182292
| Summary: | WPT tests cssom-view/scrollingElement-quirks-dynamic-*.html fail | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, cdumez, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.chromium.org/p/chromium/issues/detail?id=665927 | ||
| Bug Depends on: | 170713 | ||
| Bug Blocks: | 5991 | ||
Frédéric Wang (:fredw)
These were imported in bug 170713 and marked as failing. Current patches for bug 182230 and bug 182053 do not help. I'm opening this for the record.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Frédéric Wang (:fredw)
https://trac.webkit.org/changeset/227785/
Frédéric Wang (:fredw)
For the record, these WPT tests were added by Chromium developers in https://bugs.chromium.org/p/chromium/issues/detail?id=665927
The problem is that OverflowClip on the body depends on the one on the html element (see RenderBox::updateFromStyle()) so it makes handling dynamic update a bit more complicated. See especially https://bugs.chromium.org/p/chromium/issues/detail?id=665927#c23
In the patch for bug 182053, I'm using computedStyle() to determine the scrollingElement, which allows to always return the correct value. However, the CSS used values for overflow may still be incorrect after dynamic change which is why these tests are failing.
Ahmad Saleem
Safari Technology Preview 152 still fail these two tests and is the only browser to fail them:
https://wpt.fyi/results/css/cssom-view?label=master&label=experimental&aligned&view=subtest&q=scrollingElement-quirks-dynamic-
Just wanted to share updated status. Thanks!
Radar WebKit Bug Importer
<rdar://problem/99533462>
Ahmad Saleem
Also to consider - https://chromium.googlesource.com/chromium/blink/+/f19705cd7cadd77ff1d612396f5ccd2fa4e725a0