Bug 182044

Summary: Move css-color & css-multicol WPT suites to the proper folder
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Tools / TestsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: lforschler, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 182004    
Attachments:
Description Flags
Patch
none
Rebased patch
none
Patch for landing none

Manuel Rego Casasnovas
Reported 2018-01-24 04:33:47 PST
These suites were still under LayoutTests/imported/w3c/css/, when actually they should be under LayoutTests/imported/w3c/web-platform-tests/css/.
Attachments
Patch (1.52 MB, patch)
2018-01-24 04:35 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Rebased patch (1.46 MB, patch)
2018-01-24 08:01 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.46 MB, patch)
2018-01-24 22:59 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2018-01-24 04:35:21 PST
Created attachment 332147 [details] Patch
youenn fablet
Comment 2 2018-01-24 06:26:25 PST
Does not apply.
Manuel Rego Casasnovas
Comment 3 2018-01-24 07:22:18 PST
(In reply to youenn fablet from comment #2) > Does not apply. Dunno what happened, I'll rebase it once #182043 lands.
Manuel Rego Casasnovas
Comment 4 2018-01-24 08:01:14 PST
Created attachment 332165 [details] Rebased patch
Manuel Rego Casasnovas
Comment 5 2018-01-24 08:24:44 PST
The message about "patch does not apply to trunk of repository" seems misleading, it can be related to the size of the patch (due to moving so many files). I was getting the same message in #182043 before landing.
youenn fablet
Comment 6 2018-01-24 13:06:28 PST
Comment on attachment 332165 [details] Rebased patch r =me as long as the bots are happy. If you cannot run the bots on these ones, please make sure to looks at waterfall to ensure that no test expectation translation was missed. Patch is not too big though, so there is probably another issue.
Manuel Rego Casasnovas
Comment 7 2018-01-24 22:59:32 PST
Created attachment 332232 [details] Patch for landing
Manuel Rego Casasnovas
Comment 8 2018-01-24 23:19:33 PST
Committed r227595: <https://trac.webkit.org/changeset/227595>
Radar WebKit Bug Importer
Comment 9 2018-01-24 23:20:41 PST
<rdar://problem/36856125>
Note You need to log in before you can comment on or make changes to this bug.