Bug 181543

Summary:

Rename MarkedAllocator to BlockDirectory and AllocatorAttributes to CellAttributes

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

181559

Attachments:

Description	Flags
work in progress	none
the patch	msaboff: review+
fix style issues	none
fix webcore	none

Filip Pizlo

Reported 2018-01-11 10:18:24 PST

In a world that has thread-local caches, the thing we now call the "MarkedAllocator" doesn't really have anything to do with allocation anymore. The allocation will be done by something in the TLC. When you move the allocation logic out of MarkedAllocator, it becomes just a place to find blocks (a "block directory"). Once we do that renaming, the term "allocator attributes" becomes weird. Those are really the attributes of the HeapCellType. So let's call them CellAttributes.

Attachments
work in progress (165.47 KB, patch) 2018-01-11 10:19 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (204.23 KB, patch) 2018-01-11 14:27 PST, Filip Pizlo	msaboff: review+	Details Formatted Diff Diff
fix style issues (205.25 KB, patch) 2018-01-11 14:35 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
fix webcore (208.30 KB, patch) 2018-01-11 14:54 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2018-01-11 10:19:50 PST

Created attachment 331067 [details] work in progress

Filip Pizlo

Comment 2 2018-01-11 14:27:04 PST

Created attachment 331119 [details] the patch

Michael Saboff

Comment 3 2018-01-11 14:28:44 PST

Comment on attachment 331119 [details] the patch rs=me

EWS Watchlist

Comment 4 2018-01-11 14:29:40 PST

Attachment 331119 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/heap/IsoSubspace.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/heap/BlockDirectory.cpp:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/heap/BlockDirectory.cpp:158: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/heap/CompleteSubspace.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/heap/Subspace.cpp:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/heap/SubspaceInlines.h:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/heap/IsoSubspace.h:45: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/heap/MarkedSpace.h:26: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/heap/MarkedBlock.cpp:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/heap/MarkedBlockInlines.h:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/heap/BlockDirectory.h:118: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/heap/Heap.cpp:58: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/heap/BlockDirectoryInlines.h:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 15 in 51 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mark Lam

Comment 5 2018-01-11 14:31:16 PST

(In reply to Build Bot from comment #4) > Attachment 331119 [details] did not pass style-queue: > > > ERROR: Source/JavaScriptCore/heap/IsoSubspace.cpp:30: Alphabetical sorting > problem. [build/include_order] [4] > ERROR: Source/JavaScriptCore/heap/BlockDirectory.cpp:33: Alphabetical > sorting problem. [build/include_order] [4] > ERROR: Source/JavaScriptCore/heap/BlockDirectory.cpp:158: More than one > command on the same line [whitespace/newline] [4] > ERROR: Source/JavaScriptCore/heap/CompleteSubspace.cpp:30: Alphabetical > sorting problem. [build/include_order] [4] > ERROR: Source/JavaScriptCore/heap/MarkedSpace.cpp:28: Alphabetical sorting > problem. [build/include_order] [4] > ERROR: Source/JavaScriptCore/heap/Subspace.cpp:32: Alphabetical sorting > problem. [build/include_order] [4] > ERROR: Source/JavaScriptCore/heap/SubspaceInlines.h:29: Alphabetical > sorting problem. [build/include_order] [4] > ERROR: Source/JavaScriptCore/heap/IsoSubspace.h:45: The parameter name > "size" adds no information, so it should be removed. > [readability/parameter_name] [5] > ERROR: Source/JavaScriptCore/heap/MarkedSpace.h:26: Alphabetical sorting > problem. [build/include_order] [4] > ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:40: Alphabetical > sorting problem. [build/include_order] [4] > ERROR: Source/JavaScriptCore/heap/MarkedBlock.cpp:34: Alphabetical sorting > problem. [build/include_order] [4] > ERROR: Source/JavaScriptCore/heap/MarkedBlockInlines.h:29: Alphabetical > sorting problem. [build/include_order] [4] > ERROR: Source/JavaScriptCore/heap/BlockDirectory.h:118: Weird number of > spaces at line-start. Are you using a 4-space indent? [whitespace/indent] > [3] > ERROR: Source/JavaScriptCore/heap/Heap.cpp:58: Alphabetical sorting > problem. [build/include_order] [4] > ERROR: Source/JavaScriptCore/heap/BlockDirectoryInlines.h:28: Alphabetical > sorting problem. [build/include_order] [4] > Total errors found: 15 in 51 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. I think you can fix these. Just need to reorder the #includes since the filenames have changed.

Filip Pizlo

Comment 6 2018-01-11 14:35:12 PST

Created attachment 331121 [details] fix style issues

EWS Watchlist

Comment 7 2018-01-11 14:37:26 PST

Attachment 331121 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/heap/BlockDirectory.cpp:158: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 51 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 8 2018-01-11 14:38:19 PST

(In reply to Build Bot from comment #7) > Attachment 331121 [details] did not pass style-queue: > > > ERROR: Source/JavaScriptCore/heap/BlockDirectory.cpp:158: More than one > command on the same line [whitespace/newline] [4] > Total errors found: 1 in 51 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. I fixed this too.

Filip Pizlo

Comment 9 2018-01-11 14:54:19 PST

Created attachment 331122 [details] fix webcore

EWS Watchlist

Comment 10 2018-01-11 15:05:50 PST

Attachment 331122 [details] did not pass style-queue: ERROR: Source/WebCore/ForwardingHeaders/heap/BlockDirectoryInlines.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 1 in 54 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 11 2018-01-11 16:32:55 PST

Landed in https://trac.webkit.org/changeset/226822/webkit

Radar WebKit Bug Importer

Comment 12 2018-01-11 16:35:13 PST

<rdar://problem/36453802>

Note You need to log in before you can comment on or make changes to this bug.