Bug 181437

Summary: [Payment Request] Rename ApplePayMerchantValidationEvent to MerchantValidationEvent
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, kondapallykalyan, sam, thorton, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andy Estes
Reported 2018-01-09 08:54:30 PST
[Payment Request] Rename ApplePayMerchantValidationEvent to MerchantValidationEvent
Attachments
Patch (57.26 KB, patch)
2018-01-09 08:58 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (57.05 KB, patch)
2018-01-10 10:23 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-09 08:55:15 PST
<rdar://problem/36376481>
Andy Estes
Comment 2 2018-01-09 08:58:56 PST
Created attachment 330828 [details] Patch
EWS Watchlist
Comment 3 2018-01-09 09:02:34 PST
Attachment 330828 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.cpp:42: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 4 2018-01-09 18:00:08 PST
Comment on attachment 330828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330828&action=review > LayoutTests/http/tests/paymentrequest/payment-request-merchant-validation.https.html:2 > +<!-- Copyright (C) 2018 Apple Inc. All rights reserved. --> ?????? I don’t think so.
Andy Estes
Comment 5 2018-01-10 10:23:04 PST
Created attachment 330928 [details] Patch
WebKit Commit Bot
Comment 6 2018-01-10 13:10:19 PST
The commit-queue encountered the following flaky tests while processing attachment 330928 [details]: accessibility/mac/aria-multiple-liveregions-notification.html bug 181494 (authors: cdumez@apple.com, simon.fraser@apple.com, and zalan@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2018-01-10 13:10:21 PST
The commit-queue encountered the following flaky tests while processing attachment 330928 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2018-01-10 23:27:00 PST
Comment on attachment 330928 [details] Patch Clearing flags on attachment: 330928 Committed r226766: <https://trac.webkit.org/changeset/226766>
WebKit Commit Bot
Comment 9 2018-01-10 23:27:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.