Bug 181285

Summary:

Use no-cache fetch mode when loading main documents with location.reload()

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Service Workers

Assignee:

youenn fablet <youennf>

Status:

REOPENED

Severity:

Normal

CC:

achristensen, beidson, cdumez, commit-queue, dbates, ews-watchlist, japhet, jlewis3, rniwa, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

183132

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	none
Patch	none
Updating test	none
Archive of layout-test-results from ews103 for mac-sierra	none

youenn fablet

Reported 2018-01-04 05:01:02 PST

Use no-cache fetch mode when loading main documents with location.reload()

Attachments
Patch (12.04 KB, patch) 2018-01-04 05:22 PST, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (2.46 MB, application/zip) 2018-01-04 06:23 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (2.59 MB, application/zip) 2018-01-04 06:30 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (2.94 MB, application/zip) 2018-01-04 06:49 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.22 MB, application/zip) 2018-01-04 07:00 PST, EWS Watchlist	no flags	Details
Patch (12.09 KB, patch) 2018-01-05 08:25 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (12.38 KB, patch) 2018-01-05 09:25 PST, youenn fablet	no flags	Details Formatted Diff Diff
Updating test (14.93 KB, patch) 2018-01-10 02:43 PST, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-sierra (2.33 MB, application/zip) 2018-01-10 12:29 PST, EWS Watchlist	no flags	Details
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2018-01-04 05:22:48 PST

Created attachment 330458 [details] Patch

EWS Watchlist

Comment 2 2018-01-04 06:23:48 PST

Comment on attachment 330458 [details] Patch Attachment 330458 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5925417 New failing tests: http/tests/navigation/statistics.html http/tests/navigation/redirect-on-back-updates-history-item.html http/tests/navigation/post-frames-goback1-uncached.html http/tests/navigation/redirect-on-reload-updates-history-item.html

EWS Watchlist

Comment 3 2018-01-04 06:23:49 PST

Created attachment 330462 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 4 2018-01-04 06:30:45 PST

Comment on attachment 330458 [details] Patch Attachment 330458 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5925423 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https.html http/tests/navigation/post-frames-goback1-uncached.html

EWS Watchlist

Comment 5 2018-01-04 06:30:47 PST

Created attachment 330464 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 6 2018-01-04 06:48:58 PST

Comment on attachment 330458 [details] Patch Attachment 330458 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5925438 New failing tests: http/tests/navigation/statistics.html http/tests/navigation/redirect-on-back-updates-history-item.html http/tests/navigation/post-frames-goback1-uncached.html http/tests/navigation/redirect-on-reload-updates-history-item.html

EWS Watchlist

Comment 7 2018-01-04 06:49:00 PST

Created attachment 330465 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 8 2018-01-04 07:00:35 PST

Comment on attachment 330458 [details] Patch Attachment 330458 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5925489 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https.html http/tests/navigation/post-frames-goback1-uncached.html

EWS Watchlist

Comment 9 2018-01-04 07:00:37 PST

Created attachment 330466 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

youenn fablet

Comment 10 2018-01-05 08:25:21 PST

Created attachment 330548 [details] Patch

youenn fablet

Comment 11 2018-01-05 09:25:32 PST

Created attachment 330552 [details] Patch

youenn fablet

Comment 12 2018-01-05 10:25:53 PST

Mac-32 bit failure is unrelated.

Radar WebKit Bug Importer

Comment 13 2018-01-08 12:47:34 PST

<rdar://problem/36356831>

WebKit Commit Bot

Comment 14 2018-01-08 13:06:53 PST

Comment on attachment 330552 [details] Patch Clearing flags on attachment: 330552 Committed r226531: <https://trac.webkit.org/changeset/226531>

WebKit Commit Bot

Comment 15 2018-01-08 13:06:55 PST

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 16 2018-01-08 17:20:33 PST

This change appears to have caused LayoutTest http/tests/inspector/network/har/har-page.html to fail: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r226581%20(6756)/results.html I can reproduce the failure locally with a build of 226531, I cannot reproduce with 226528.

Matt Lewis

Comment 17 2018-01-09 15:00:53 PST

Reverted r226531 for reason: This caused test failures on macOS WK2. Committed r226659: <https://trac.webkit.org/changeset/226659>

youenn fablet

Comment 18 2018-01-10 02:30:36 PST

(In reply to Ryan Haddad from comment #16) > This change appears to have caused LayoutTest > http/tests/inspector/network/har/har-page.html to fail: > https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/ > r226581%20(6756)/results.html > > I can reproduce the failure locally with a build of 226531, I cannot > reproduce with 226528. Failure is "cookies": [], "headers": "<filtered>", "content": { - "size": 3042, + "size": 0, "compression": 0, "mimeType": "text/html", "text": "<filtered text (3042)>" size can be set to zero even if text is not empty in case of 304 responses I think. I will change the test to filter the "size" parameter since cache may or may not contain those resources.

youenn fablet

Comment 19 2018-01-10 02:43:14 PST

Created attachment 330884 [details] Updating test

WebKit Commit Bot

Comment 20 2018-01-10 11:48:54 PST

The commit-queue encountered the following flaky tests while processing attachment 330884 [details]: The commit-queue is continuing to process your patch.

EWS Watchlist

Comment 21 2018-01-10 12:29:57 PST

Comment on attachment 330884 [details] Updating test Attachment 330884 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6023842 New failing tests: http/tests/misc/slow-loading-animated-image.html

EWS Watchlist

Comment 22 2018-01-10 12:29:59 PST

Created attachment 330947 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

WebKit Commit Bot

Comment 23 2018-01-10 16:45:54 PST

Comment on attachment 330884 [details] Updating test Clearing flags on attachment: 330884 Committed r226745: <https://trac.webkit.org/changeset/226745>

WebKit Commit Bot

Comment 24 2018-01-10 16:45:56 PST

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 25 2018-02-26 09:34:49 PST

Re-opened since this is blocked by bug 183132

Note You need to log in before you can comment on or make changes to this bug.