Bug 181197

Summary:

feLighting is broken with primitiveUnits="objectBoundingBox"

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

SVG

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, ews-watchlist, rniwa, sabouhallawa, simon.fraser, thorton, webkit-bug-importer, zimmermann

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

181147

Bug Blocks:

Attachments:

Description	Flags
Testcase	none
Patch	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
Patch	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews112 for mac-elcapitan	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch	none

Simon Fraser (smfr)

Reported 2017-12-30 22:08:09 PST

Created attachment 330266 [details] Testcase We never resolve light positions correctly with primitiveUnits="objectBoundingBox"

Attachments
Testcase (421 bytes, image/svg+xml) 2017-12-30 22:08 PST, Simon Fraser (smfr)	no flags	Details
Patch (24.05 KB, patch) 2018-01-01 09:32 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (2.42 MB, application/zip) 2018-01-01 10:29 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (2.76 MB, application/zip) 2018-01-01 10:43 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.65 MB, application/zip) 2018-01-01 10:57 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (3.10 MB, application/zip) 2018-01-01 11:06 PST, EWS Watchlist	no flags	Details
Patch (24.03 KB, patch) 2018-01-01 12:48 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (2.43 MB, application/zip) 2018-01-01 13:45 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (2.85 MB, application/zip) 2018-01-01 13:58 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-elcapitan (3.12 MB, application/zip) 2018-01-01 14:08 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.64 MB, application/zip) 2018-01-01 14:14 PST, EWS Watchlist	no flags	Details
Patch (24.09 KB, patch) 2018-01-03 11:42 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2018-01-01 09:32:13 PST Comment hidden (obsolete)

Created attachment 330285 [details] Patch

EWS Watchlist

Comment 2 2018-01-01 10:29:49 PST Comment hidden (obsolete)

Comment on attachment 330285 [details] Patch Attachment 330285 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5885666 New failing tests: svg/filters/feDiffuseLighting-fePointLight-primitiveUnits-objectBoundingBox.svg svg/filters/feSpecularLighting-fePointLight-primitiveUnits-objectBoundingBox.svg svg/filters/feDiffuseLighting-feSpotLight-primitiveUnits-objectBoundingBox.svg

EWS Watchlist

Comment 3 2018-01-01 10:29:51 PST Comment hidden (obsolete)

Created attachment 330287 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 4 2018-01-01 10:43:45 PST Comment hidden (obsolete)

Comment on attachment 330285 [details] Patch Attachment 330285 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5885708 New failing tests: svg/filters/feDiffuseLighting-fePointLight-primitiveUnits-objectBoundingBox.svg svg/filters/feSpecularLighting-fePointLight-primitiveUnits-objectBoundingBox.svg svg/filters/feDiffuseLighting-feSpotLight-primitiveUnits-objectBoundingBox.svg

EWS Watchlist

Comment 5 2018-01-01 10:43:46 PST Comment hidden (obsolete)

Created attachment 330288 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 6 2018-01-01 10:57:46 PST Comment hidden (obsolete)

Comment on attachment 330285 [details] Patch Attachment 330285 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5885756 New failing tests: svg/filters/feDiffuseLighting-fePointLight-primitiveUnits-objectBoundingBox.svg svg/filters/feSpecularLighting-fePointLight-primitiveUnits-objectBoundingBox.svg svg/filters/feDiffuseLighting-feSpotLight-primitiveUnits-objectBoundingBox.svg

EWS Watchlist

Comment 7 2018-01-01 10:57:47 PST Comment hidden (obsolete)

Created attachment 330289 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-01-01 11:06:35 PST Comment hidden (obsolete)

Comment on attachment 330285 [details] Patch Attachment 330285 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5885766 New failing tests: svg/filters/feDiffuseLighting-fePointLight-primitiveUnits-objectBoundingBox.svg svg/filters/feSpecularLighting-fePointLight-primitiveUnits-objectBoundingBox.svg svg/filters/feDiffuseLighting-feSpotLight-primitiveUnits-objectBoundingBox.svg

EWS Watchlist

Comment 9 2018-01-01 11:06:37 PST Comment hidden (obsolete)

Created attachment 330291 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Simon Fraser (smfr)

Comment 10 2018-01-01 12:48:07 PST Comment hidden (obsolete)

Created attachment 330296 [details] Patch

EWS Watchlist

Comment 11 2018-01-01 13:45:35 PST Comment hidden (obsolete)

Comment on attachment 330296 [details] Patch Attachment 330296 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5887129 New failing tests: svg/filters/feDiffuseLighting-fePointLight-primitiveUnits-objectBoundingBox.svg svg/filters/feSpecularLighting-fePointLight-primitiveUnits-objectBoundingBox.svg svg/filters/feDiffuseLighting-feSpotLight-primitiveUnits-objectBoundingBox.svg

EWS Watchlist

Comment 12 2018-01-01 13:45:37 PST Comment hidden (obsolete)

Created attachment 330297 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 13 2018-01-01 13:58:15 PST Comment hidden (obsolete)

Comment on attachment 330296 [details] Patch Attachment 330296 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5887153 New failing tests: svg/filters/feDiffuseLighting-fePointLight-primitiveUnits-objectBoundingBox.svg svg/filters/feSpecularLighting-fePointLight-primitiveUnits-objectBoundingBox.svg svg/filters/feDiffuseLighting-feSpotLight-primitiveUnits-objectBoundingBox.svg

EWS Watchlist

Comment 14 2018-01-01 13:58:17 PST Comment hidden (obsolete)

Created attachment 330298 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 15 2018-01-01 14:08:56 PST Comment hidden (obsolete)

Comment on attachment 330296 [details] Patch Attachment 330296 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5887161 New failing tests: svg/filters/feDiffuseLighting-fePointLight-primitiveUnits-objectBoundingBox.svg svg/filters/feSpecularLighting-fePointLight-primitiveUnits-objectBoundingBox.svg svg/filters/feDiffuseLighting-feSpotLight-primitiveUnits-objectBoundingBox.svg

EWS Watchlist

Comment 16 2018-01-01 14:08:58 PST Comment hidden (obsolete)

Created attachment 330299 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 17 2018-01-01 14:14:49 PST Comment hidden (obsolete)

Comment on attachment 330296 [details] Patch Attachment 330296 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5887173 New failing tests: svg/filters/feDiffuseLighting-fePointLight-primitiveUnits-objectBoundingBox.svg svg/filters/feSpecularLighting-fePointLight-primitiveUnits-objectBoundingBox.svg svg/filters/feDiffuseLighting-feSpotLight-primitiveUnits-objectBoundingBox.svg

EWS Watchlist

Comment 18 2018-01-01 14:14:50 PST Comment hidden (obsolete)

Created attachment 330301 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Simon Fraser (smfr)

Comment 19 2018-01-03 11:42:43 PST

Created attachment 330404 [details] Patch

WebKit Commit Bot

Comment 20 2018-01-03 13:56:03 PST

Comment on attachment 330404 [details] Patch Clearing flags on attachment: 330404 Committed r226373: <https://trac.webkit.org/changeset/226373>

WebKit Commit Bot

Comment 21 2018-01-03 13:56:05 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 22 2018-01-03 13:57:46 PST

<rdar://problem/36283115>

Note You need to log in before you can comment on or make changes to this bug.