Bug 180456

Summary: InferredType should not use UnconditionalFinalizer
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 180248    
Attachments:
Description Flags
it's a start
none
the patch
saam: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews115 for mac-elcapitan
none
patch for landing none

Filip Pizlo
Reported 2017-12-05 16:25:43 PST
Patch forthcoming.
Attachments
it's a start (36.22 KB, patch)
2017-12-05 16:27 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (37.56 KB, patch)
2017-12-05 17:32 PST, Filip Pizlo 		saam: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews115 for mac-elcapitan (1.88 MB, application/zip)
2017-12-05 18:41 PST, EWS Watchlist 		no flags
Details
patch for landing (38.07 KB, patch)
2017-12-05 19:08 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-12-05 16:27:10 PST
Created attachment 328523 [details] it's a start
Filip Pizlo
Comment 2 2017-12-05 17:32:49 PST
Created attachment 328538 [details] the patch
Saam Barati
Comment 3 2017-12-05 17:39:35 PST
Comment on attachment 328538 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=328538&action=review > Source/JavaScriptCore/runtime/InferredType.cpp:90 > + if (inferredType->m_structure) > + visitor.append(inferredType->m_structure); Doesn't append already do a null check for you?
Filip Pizlo
Comment 4 2017-12-05 17:42:25 PST
(In reply to Saam Barati from comment #3) > Comment on attachment 328538 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=328538&action=review > > > Source/JavaScriptCore/runtime/InferredType.cpp:90 > > + if (inferredType->m_structure) > > + visitor.append(inferredType->m_structure); > > Doesn't append already do a null check for you? Yeah you're right!
EWS Watchlist
Comment 5 2017-12-05 18:41:22 PST
Comment on attachment 328538 [details] the patch Attachment 328538 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5508914 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 6 2017-12-05 18:41:23 PST
Created attachment 328543 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Filip Pizlo
Comment 7 2017-12-05 19:08:59 PST
Created attachment 328546 [details] patch for landing This fixes some crashes
Filip Pizlo
Comment 8 2017-12-09 11:48:26 PST
Landed in https://trac.webkit.org/changeset/225725/webkit
Radar WebKit Bug Importer
Comment 9 2017-12-09 11:49:26 PST
<rdar://problem/35953018>
Note You need to log in before you can comment on or make changes to this bug.