Bug 180108

Summary: CodeBlockSet::deleteUnmarkedAndUnreferenced can be a little more efficient
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 165909    
Attachments:
Description Flags
the patch saam: review+

Filip Pizlo
Reported 2017-11-28 13:48:13 PST
Patch forthcoming.
Attachments
the patch (3.05 KB, patch)
2017-11-28 13:58 PST, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-11-28 13:58:47 PST
Created attachment 327784 [details] the patch
Saam Barati
Comment 2 2017-11-28 14:06:08 PST
Comment on attachment 327784 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=327784&action=review r=me > Source/JavaScriptCore/heap/CodeBlockSet.cpp:31 > +#include "SuperSampler.h" You're not using this AFAICT > Source/JavaScriptCore/heap/CodeBlockSet.cpp:87 > + // FIXME: make CodeBlock::~CodeBlock a lot faster. It seems insane for that to take 1us or more. Indeed. That's crazy
Filip Pizlo
Comment 3 2017-11-29 20:49:13 PST
Landed in https://trac.webkit.org/changeset/225315/webkit
Radar WebKit Bug Importer
Comment 4 2017-11-29 20:50:35 PST
<rdar://problem/35765296>
Note You need to log in before you can comment on or make changes to this bug.