Bug 179903

Summary: [ESNext][BigInt] Support logic operations
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Caio Lima <ticaiolima>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, rniwa, ryanhaddad, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 179001    
Attachments:
Description Flags
WIP - Patch
none
WIP - Patch
none
Patch
none
WIP - Patch
none
Archive of layout-test-results from ews102 for mac-sierra
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews117 for mac-sierra none

Caio Lima
Reported 2017-11-20 16:11:35 PST
Support operations like "&&" and "||" with BigInt.
Attachments
WIP - Patch (15.35 KB, patch)
2018-10-16 12:16 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
WIP - Patch (15.49 KB, patch)
2018-10-16 17:51 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (15.52 KB, patch)
2018-11-01 17:33 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
WIP - Patch (15.48 KB, patch)
2018-11-08 06:56 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-sierra (2.57 MB, application/zip)
2018-11-08 07:59 PST, EWS Watchlist 		no flags
Details
Patch (15.79 KB, patch)
2018-11-13 15:46 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (15.84 KB, patch)
2018-11-14 08:35 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (15.75 KB, patch)
2018-11-18 16:36 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (15.75 KB, patch)
2018-11-26 03:59 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (15.73 KB, patch)
2018-11-28 05:35 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (15.78 KB, patch)
2018-12-03 16:20 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Patch (15.78 KB, patch)
2018-12-04 03:33 PST, Caio Lima 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews117 for mac-sierra (2.04 MB, application/zip)
2018-12-04 06:11 PST, EWS Watchlist 		no flags
Details
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.
Caio Lima
Comment 1 2018-10-16 12:16:43 PDT
Created attachment 352488 [details] WIP - Patch
Caio Lima
Comment 2 2018-10-16 17:51:26 PDT
Created attachment 352527 [details] WIP - Patch
Caio Lima
Comment 3 2018-10-22 11:33:28 PDT
*** Bug 186231 has been marked as a duplicate of this bug. ***
Caio Lima
Comment 4 2018-10-22 11:33:56 PDT
*** Bug 186230 has been marked as a duplicate of this bug. ***
Caio Lima
Comment 5 2018-10-22 11:44:32 PDT
*** Bug 182215 has been marked as a duplicate of this bug. ***
Caio Lima
Comment 6 2018-11-01 17:33:43 PDT
Created attachment 353670 [details] Patch
Caio Lima
Comment 7 2018-11-08 06:56:22 PST
Created attachment 354236 [details] WIP - Patch
EWS Watchlist
Comment 8 2018-11-08 07:59:19 PST
Comment on attachment 354236 [details] WIP - Patch Attachment 354236 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9909202 New failing tests: http/wpt/css/css-animations/start-animation-001.html
EWS Watchlist
Comment 9 2018-11-08 07:59:21 PST
Created attachment 354240 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Caio Lima
Comment 10 2018-11-13 15:46:48 PST
Created attachment 354714 [details] Patch
Caio Lima
Comment 11 2018-11-14 08:35:34 PST
Created attachment 354812 [details] Patch
Caio Lima
Comment 12 2018-11-18 16:36:17 PST
Created attachment 355244 [details] Patch
Caio Lima
Comment 13 2018-11-26 03:59:38 PST
Created attachment 355634 [details] Patch
Caio Lima
Comment 14 2018-11-28 05:35:20 PST
Created attachment 355865 [details] Patch
Caio Lima
Comment 15 2018-11-28 13:35:42 PST
Ping Review
Yusuke Suzuki
Comment 16 2018-12-02 00:40:00 PST
Comment on attachment 355865 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355865&action=review r=me with nits. > Source/JavaScriptCore/runtime/JSBigInt.cpp:1680 > +bool JSBigInt::toBoolean() const > +{ > + return !isZero(); > +} This function is very very small. I think we should define `isZero` and `toBoolean` as inline functions in JSBigInt.h (inside the class JSBigInt definition).
Caio Lima
Comment 17 2018-12-03 16:20:37 PST
Created attachment 356431 [details] Patch
EWS Watchlist
Comment 18 2018-12-03 16:22:38 PST
Attachment 356431 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSBigInt.h:202: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Caio Lima
Comment 19 2018-12-03 16:22:55 PST
Comment on attachment 356431 [details] Patch Thank you very much for the review!
WebKit Commit Bot
Comment 20 2018-12-03 17:12:12 PST
The commit-queue encountered the following flaky tests while processing attachment 356431 [details]: webgl/2.0.0/conformance/more/functions/copyTexImage2D.html bug 192343 (author: justin_fan@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 21 2018-12-03 17:13:10 PST
Comment on attachment 356431 [details] Patch Clearing flags on attachment: 356431 Committed r238833: <https://trac.webkit.org/changeset/238833>
WebKit Commit Bot
Comment 22 2018-12-03 17:13:12 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 23 2018-12-03 17:14:33 PST
<rdar://problem/46438082>
Ryan Haddad
Comment 24 2018-12-03 17:22:50 PST
As EWS indicated in https://webkit-queues.webkit.org/results/10255942, this change broke macOS Debug builds: ERROR: JavaScriptCore has a weak external symbol in it (/Volumes/Data/slave/mojave-debug/build/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore) ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library. ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file. ERROR: symbol __ZNK3JSC8JSBigInt9toBooleanEv
Ryan Haddad
Comment 25 2018-12-03 17:34:34 PST
Reverted r238833 for reason: Breaks macOS and iOS debug builds. Committed r238835: <https://trac.webkit.org/changeset/238835>
Caio Lima
Comment 26 2018-12-04 03:33:28 PST
Created attachment 356482 [details] Patch
EWS Watchlist
Comment 27 2018-12-04 03:36:41 PST
Attachment 356482 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSBigInt.h:202: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 28 2018-12-04 06:11:06 PST
Comment on attachment 356482 [details] Patch Attachment 356482 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10262081 New failing tests: http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable.html
EWS Watchlist
Comment 29 2018-12-04 06:11:07 PST
Created attachment 356490 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Caio Lima
Comment 30 2018-12-04 10:29:30 PST
(In reply to Build Bot from comment #28) > Comment on attachment 356482 [details] > Patch > > Attachment 356482 [details] did not pass mac-debug-ews (mac): > Output: https://webkit-queues.webkit.org/results/10262081 > > New failing tests: > http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable.html Regression not related with this Patch.
WebKit Commit Bot
Comment 31 2018-12-04 10:55:33 PST
Comment on attachment 356482 [details] Patch Clearing flags on attachment: 356482 Committed r238861: <https://trac.webkit.org/changeset/238861>
WebKit Commit Bot
Comment 32 2018-12-04 10:55:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.