Bug 179191

Summary:

Import 2dcontext Web Platform Tests

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Chris Lord <clord>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, cdumez, clord, commit-queue, eric.carlson, ews-watchlist, fred.wang, glenn, jer.noble, philipj, rniwa, rwlbuis, sergio, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf, zan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

183720, 202458, 202459, 202460, 202516, 202517, 202518, 202523, 182686, 202455, 202457

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Dean Jackson

Reported 2017-11-02 12:30:17 PDT

Import OffscreenCanvas Web Platform Tests

Attachments
Patch (3.91 MB, patch) 2017-11-02 12:39 PDT, Dean Jackson	no flags	Details Formatted Diff Diff
Patch for landing (3.91 MB, patch) 2017-11-02 13:49 PDT, Dean Jackson	no flags	Details Formatted Diff Diff
Patch (7.01 MB, patch) 2019-10-01 04:52 PDT, Chris Lord	no flags	Details Formatted Diff Diff
Patch (8.20 MB, patch) 2019-10-02 07:05 PDT, Chris Lord	no flags	Details Formatted Diff Diff
Patch (8.20 MB, patch) 2019-10-02 08:41 PDT, Chris Lord	no flags	Details Formatted Diff Diff
Patch (3.37 MB, patch) 2019-10-03 02:54 PDT, Chris Lord	no flags	Details Formatted Diff Diff
Patch (3.37 MB, patch) 2019-10-03 03:47 PDT, Chris Lord	no flags	Details Formatted Diff Diff
Patch (3.37 MB, patch) 2019-10-03 06:54 PDT, Chris Lord	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-11-02 12:31:25 PDT

<rdar://problem/35320416>

Dean Jackson

Comment 2 2017-11-02 12:39:42 PDT

Created attachment 325750 [details] Patch

Dean Jackson

Comment 3 2017-11-02 13:49:00 PDT

Created attachment 325764 [details] Patch for landing

Chris Lord

Comment 4 2019-10-01 04:52:04 PDT

Created attachment 379893 [details] Patch

youenn fablet

Comment 5 2019-10-01 04:57:54 PDT

Comment on attachment 379893 [details] Patch r=me if bots are happy. If it proves difficult to have bots happy, you could try splitting the patch in 2dcontext and offlinecanvas.

Chris Lord

Comment 6 2019-10-02 06:13:22 PDT

I realised this patch missed setting the baseline for the offscreen-canvas tests (whoops!) - I'm just in the process of investigating the platform differences and filing the relevant bugs, it'll likely take a few more EWS submissions to get this green.

Chris Lord

Comment 7 2019-10-02 07:05:51 PDT

Created attachment 380016 [details] Patch

Chris Lord

Comment 8 2019-10-02 08:41:03 PDT

Created attachment 380024 [details] Patch

Aakash Jain

Comment 9 2019-10-02 11:13:38 PDT

Since this is a large patch (8 mb), svn-apply is taking very long time to apply this patch (2+ hours on some bots, e.g.: https://ews-build.webkit.org/#/builders/7/builds/10606). I cancelled the build on 'style' queue so that other patches can be processed, will retry it later when the bot is relatively free.

Chris Lord

Comment 10 2019-10-02 12:21:24 PDT

(In reply to Aakash Jain from comment #9) > Since this is a large patch (8 mb), svn-apply is taking very long time to > apply this patch (2+ hours on some bots, e.g.: > https://ews-build.webkit.org/#/builders/7/builds/10606). > > I cancelled the build on 'style' queue so that other patches can be > processed, will retry it later when the bot is relatively free. Thanks - I think for future revisions, I'll split this patch into the offscreen-canvas tests and the 2dcontext tests - though I think the size of the latter may be the larger part of this patch...

Chris Lord

Comment 11 2019-10-03 02:54:59 PDT

Created attachment 380094 [details] Patch

Chris Lord

Comment 12 2019-10-03 03:47:10 PDT

Created attachment 380098 [details] Patch

Chris Lord

Comment 13 2019-10-03 06:54:26 PDT

Created attachment 380108 [details] Patch

Chris Lord

Comment 14 2019-10-03 06:56:04 PDT

I believe this latest test will be green, so I'm marking it for review/committing. I'll hold off on bug 202513 until this lands.