Bug 179108

Created attachment 325553 [details] WIP Patch

This is great. I'm very interested to see the pass rate :)

(In reply to Myles C. Maxfield from comment #2) > This is great. I'm very interested to see the pass rate :) OK, I'm submitting it to EWS just to check mac and iOS. However, when I tried on GTK all the test fails so I was wondering whether something was wrong with the test configuration (while I know that https://www.w3.org/TR/WOFF2/#conform-mustNotRejectIncorrectTotalSize should definitely pass). Maybe something funny with the *.xht extensions, don't know. I did not have time to debug further unfortunately.

Comment on attachment 325553 [details] WIP Patch Attachment 325553 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5087236 Number of test failures exceeded the failure limit.

Created attachment 325870 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Comment on attachment 325553 [details] WIP Patch Attachment 325553 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5087370 Number of test failures exceeded the failure limit.

Created attachment 325873 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Comment on attachment 325553 [details] WIP Patch Attachment 325553 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5087369 Number of test failures exceeded the failure limit.

Created attachment 325875 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Comment on attachment 325553 [details] WIP Patch Attachment 325553 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5087377 Number of test failures exceeded the failure limit.

Created attachment 325876 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

(In reply to Frédéric Wang (:fredw) from comment #3) > (In reply to Myles C. Maxfield from comment #2) > > This is great. I'm very interested to see the pass rate :) > > OK, I'm submitting it to EWS just to check mac and iOS. However, when I > tried on GTK all the test fails so I was wondering whether something was > wrong with the test configuration (while I know that > https://www.w3.org/TR/WOFF2/#conform-mustNotRejectIncorrectTotalSize should > definitely pass). Maybe something funny with the *.xht extensions, don't > know. I did not have time to debug further unfortunately. Tests seem to fail on macOS and iOS too. Mozilla has them in https://hg.mozilla.org/mozilla-central/file/tip/testing/web-platform/tests/css/WOFF2 And I opened https://bugs.chromium.org/p/chromium/issues/detail?id=781154 for chromium.

OK, the problem was just that the tests require the fonts in web-platform-tests/css/WOFF2/support/FontsToInstall to be installed. When I copy them into webkitgtk-test-fonts/, I get the following results on WebKitGTK: 297 tests ran as expected, 4 didn't: imported/w3c/web-platform-tests/css/WOFF2/tabledata-glyf-bbox-001.xht imported/w3c/web-platform-tests/css/WOFF2/tabledata-glyf-origlength-001.xht imported/w3c/web-platform-tests/css/WOFF2/tabledata-glyf-origlength-002.xht imported/w3c/web-platform-tests/css/WOFF2/tabledata-recontruct-loca-001.xht (these tests only fail because of some spacing issue, but the "PASS" message is displayed) IIRC, on macOS/iOS one has to put the fonts in another place in Tools/ and "whitelist" them for the tests. I wonder whether it would be better to address that directly at the web-platform-tests repo and I've opened https://github.com/w3c/web-platform-tests/issues/8440

(In reply to Frédéric Wang (:fredw) from comment #13) > OK, the problem was just that the tests require the fonts in > web-platform-tests/css/WOFF2/support/FontsToInstall to be installed. When I > copy them into webkitgtk-test-fonts/, I get the following results on > WebKitGTK: > > 297 tests ran as expected, 4 didn't: > imported/w3c/web-platform-tests/css/WOFF2/tabledata-glyf-bbox-001.xht > imported/w3c/web-platform-tests/css/WOFF2/tabledata-glyf-origlength-001.xht > imported/w3c/web-platform-tests/css/WOFF2/tabledata-glyf-origlength-002.xht > imported/w3c/web-platform-tests/css/WOFF2/tabledata-recontruct-loca-001.xht > > (these tests only fail because of some spacing issue, but the "PASS" message > is displayed) > > IIRC, on macOS/iOS one has to put the fonts in another place in Tools/ and > "whitelist" them for the tests. > > I wonder whether it would be better to address that directly at the > web-platform-tests repo and I've opened > https://github.com/w3c/web-platform-tests/issues/8440 Yeah, using web fonts definitely makes the tests easier to run and integrate into our testing infrastructure.

Created attachment 327737 [details] WIP Patch This version includes https://github.com/w3c/web-platform-tests/commit/3ffcc989b15d7bd671c3ddd22f3c2b90152165de I have about 90% of success on macOS.

Comment on attachment 327737 [details] WIP Patch Attachment 327737 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5387239 Number of test failures exceeded the failure limit.

Created attachment 327740 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Comment on attachment 327737 [details] WIP Patch Attachment 327737 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5387260 Number of test failures exceeded the failure limit.

Created attachment 327741 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Comment on attachment 327737 [details] WIP Patch Attachment 327737 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5387255 Number of test failures exceeded the failure limit.

Created attachment 327742 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Comment on attachment 327737 [details] WIP Patch Attachment 327737 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5387320 New failing tests: imported/w3c/web-platform-tests/css/WOFF2/tabledata-bad-origlength-loca-002.xht imported/w3c/web-platform-tests/css/WOFF2/tabledata-bad-origlength-loca-001.xht imported/w3c/web-platform-tests/css/WOFF2/tabledata-transform-hmtx-003.xht imported/w3c/web-platform-tests/css/WOFF2/directory-mismatched-tables-001.xht imported/w3c/web-platform-tests/css/WOFF2/tabledata-glyf-origlength-002.xht imported/w3c/web-platform-tests/css/WOFF2/tabledata-glyf-bbox-003.xht imported/w3c/web-platform-tests/css/WOFF2/tabledata-glyf-bbox-001.xht imported/w3c/web-platform-tests/css/WOFF2/tabledata-glyf-origlength-001.xht imported/w3c/web-platform-tests/css/WOFF2/blocks-extraneous-data-002.xht imported/w3c/web-platform-tests/css/WOFF2/datatypes-invalid-base128-003.xht

Created attachment 327743 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Created attachment 341179 [details] Patch

@Youenn: Can you please review this? Given the discussions with new WPT tests (in particular bug 178277) and since macOS/iOS ports fail many WOFF2 tests, for now I'm skipping the WOFF2 tests on all platforms by default and only enabling them on the GTK port. I opened bug 185939 for follow-up work.

Comment on attachment 341179 [details] Patch Attachment 341179 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7790481 New failing tests: http/tests/security/video-poster-cross-origin-crash2.html

Created attachment 341214 [details] Archive of layout-test-results from ews201 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Committed r232183: <https://trac.webkit.org/changeset/232183>

<rdar://problem/40546115>