Bug 179038

Summary: [WPE][GTK] Always use SET_AND_EXPOSE_TO_BUILD to set build variables
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WPE WebKitAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, mcatanzaro, tpopela, webkit-bug-importer, zan
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 178894    
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2017-10-30 17:28:37 PDT
Always use SET_AND_EXPOSE_TO_BUILD to set build variables (as noted by Tom) This doesn't actually fix anything, but it's quite risky not to do so, as build defines could wind up set to unexpected values.
Attachments
Patch (2.71 KB, patch)
2017-10-30 19:40 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-10-30 19:40:04 PDT
Created attachment 325413 [details] Patch
WebKit Commit Bot
Comment 2 2017-11-06 06:43:44 PST
Comment on attachment 325413 [details] Patch Clearing flags on attachment: 325413 Committed r224490: <https://trac.webkit.org/changeset/224490>
WebKit Commit Bot
Comment 3 2017-11-06 06:43:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.