Bug 178902

Summary: Windows and WebViews are retained after re-configure
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, lforschler, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186542
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2017-10-26 17:12:37 PDT
Because the AutoRelease pool is declared in main, we don't release Windows and WebViews when a test changes configuration settings. This is, in effect, a memory leak when running layout tests. Note that this isn't the only memory leak when running WK2 layout tests.
Attachments
Patch (1.64 KB, patch)
2017-10-26 17:24 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.65 KB, patch)
2017-10-27 07:45 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-10-26 17:17:00 PDT
<rdar://problem/35211518>
Radar WebKit Bug Importer
Comment 2 2017-10-26 17:17:01 PDT
<rdar://problem/35211519>
Jonathan Bedard
Comment 3 2017-10-26 17:24:35 PDT
Created attachment 325083 [details] Patch
Alexey Proskuryakov
Comment 4 2017-10-26 17:48:57 PDT
Comment on attachment 325083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325083&action=review > Tools/WebKitTestRunner/TestController.cpp:1180 > + WTF::AutodrainedPool pool; Please remove "WTF::", AutodrainedPool is exported to the global scope (as should all public WTF symbols).
Jonathan Bedard
Comment 5 2017-10-27 07:45:05 PDT
Created attachment 325161 [details] Patch for landing
WebKit Commit Bot
Comment 6 2017-10-27 10:21:16 PDT
The commit-queue encountered the following flaky tests while processing attachment 325161 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2017-10-27 12:10:28 PDT
Comment on attachment 325161 [details] Patch for landing Clearing flags on attachment: 325161 Committed r224124: <https://trac.webkit.org/changeset/224124>
WebKit Commit Bot
Comment 8 2017-10-27 12:10:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.