Bug 178643

Summary: [Web Animations] Add animations to the timeline
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, dino, esprehn+autocc, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=122912
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Antoine Quint
Reported 2017-10-22 05:22:26 PDT
[Web Animations] Add animations to the timeline
Attachments
Patch (8.91 KB, patch)
2017-10-22 05:25 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (8.91 KB, patch)
2017-10-22 06:55 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (9.37 KB, patch)
2017-10-22 10:16 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2017-10-22 05:25:14 PDT
Created attachment 324524 [details] Patch
Antoine Quint
Comment 2 2017-10-22 06:55:30 PDT
Created attachment 324525 [details] Patch
Antoine Quint
Comment 3 2017-10-22 10:16:47 PDT
Created attachment 324529 [details] Patch
Dean Jackson
Comment 4 2017-10-22 13:01:34 PDT
Comment on attachment 324529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324529&action=review > Source/WebCore/animation/AnimationTimeline.cpp:60 > + stream << (m_classType == DocumentTimelineClass ? "DocumentTimeline" : "AnimationTimeline") << " with " << m_animations.size() << " animations:"; > + stream << "\n"; why not put this on the previous line? > Source/WebCore/animation/AnimationTimeline.cpp:64 > + stream << count << ". " << animation->description(); > + stream << "\n"; same
WebKit Commit Bot
Comment 5 2017-10-22 14:31:28 PDT
Comment on attachment 324529 [details] Patch Clearing flags on attachment: 324529 Committed r223825: <https://trac.webkit.org/changeset/223825>
WebKit Commit Bot
Comment 6 2017-10-22 14:31:29 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-10-31 06:40:53 PDT
<rdar://problem/35271075>
Note You need to log in before you can comment on or make changes to this bug.